Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lang attribute to the html element#1133 #1143

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

Straw4yu
Copy link
Contributor

@Straw4yu Straw4yu commented Oct 13, 2022

Fixes #1133 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [*] PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • [*] code is in uniquely-named feature branch and has no merge conflicts 📁
  • [*] screenshots/GIFs are attached 📎 in case of UI updates
  • [*] @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Oct 13, 2022

@Straw4yu
Copy link
Contributor Author

I think it's great

@leilayesufu
Copy link
Contributor

Hii, @Straw4yu
This looks great to me, let’s wait for @TildaDares to give the final review

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @Straw4yu. Thank you!

@TildaDares
Copy link
Member

Thanks for the reviews @leilayesufu!!

@TildaDares TildaDares merged commit 6e426d8 into publiclab:main Oct 13, 2022
@welcome
Copy link

welcome bot commented Oct 13, 2022

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@TildaDares
Copy link
Member

Congratulations on merging your PR @Straw4yu 🎉🎉

@leilayesufu
Copy link
Contributor

Anytime!! @TildaDares
Can I close the issue now?

@TildaDares
Copy link
Member

Yes you can @leilayesufu. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add lang attribute to the html element
3 participants