resolve trapezoidal distortion issues with project() instead of .latLngToLayerPoint()

[jywarren]

WIP fix for part of #301 #85

[jywarren]

@sashadev-sky this was a partial solution, i think? Should we merge this to narrow the issue?

[sashadev-sky]

@jywarren
Woah so glad I decided to look over this tonight! I am pretty sure it completely fixes scale. Walking through it, I think it makes sense.

• We get the center of the image using latLngToLayerPoint because that calculation is done relative to the image itself
• but we have to project the coordinates so that they are relative to the absolute pixel coordinates, then do the calculations, then unproject. Basically because the image lives in the context of the map so any calculations involving projecting it over the map need to use project

Going to merge.. and try to write some tests for this 👍Did you say there was a 2nd problem with scale?

[sashadev-sky]

@jywarren Also, I was tempted to bump the package # but we are starting to do that more often than not for PRs. I was wondering if that is a common practice for non-breaking bugs for a library that is meant to be used as a dependency? It's a little confusing for me because I understand that some libraries fix the bugs but wait until a batch of updates to release before publishing?

[jywarren]

Oh cool! Awesome! I think a few downstream users have reported scale/distort bugs recently so hopefully this addresses those? As to releases, I think it's good practice to release at 0.0.x (patch) for any bugfix. If people want a slower, more stable release schedule, they can use semver syntax in their package.json to point at only "minor" releases, so 0.x.0. If you'd like, we can start using `0.0.0-rc1` (i think?) syntax to offer release candidates for minor releases, before releasing a 0.x.0, so as to let some bugs shake out first. But it's getting a little granular!

…

On Fri, Aug 9, 2019 at 10:47 AM Sasha Boginsky ***@***.***> wrote: Merged #341 <#341> into main. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#341?email_source=notifications&email_token=AAAF6J4CGGFWGIHMGUB2F5LQDTZF5A5CNFSM4IABHGU2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOS63I5RA#event-2545323716>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J7OBGRC34UN7DWP5BTQDTZF5ANCNFSM4IABHGUQ> .

[sashadev-sky]

@jywarren I don't feel compelled to use it unless you would like to! Maybe we should revisit this after publishing version 1?

[jywarren]

Sure, sounds good!

…

On Sun, Aug 11, 2019 at 5:43 AM Sasha Boginsky ***@***.***> wrote: @jywarren <https://github.com/jywarren> I don't feel compelled to use it unless you would like to! Maybe we should revisit this after publishing version 1? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#341?email_source=notifications&email_token=AAAF6J3G5C2LCYTQXTZSB53QD7NJNA5CNFSM4IABHGU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4A5PBI#issuecomment-520214405>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J2RHZH724TYTVSBV53QD7NJNANCNFSM4IABHGUQ> .