Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add dynamic-hotkeys functionality #387

Merged
merged 4 commits into from
Aug 20, 2019
Merged

[WIP] add dynamic-hotkeys functionality #387

merged 4 commits into from
Aug 20, 2019

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Aug 16, 2019

Fixes #376

cc @sashadev-sky @jywarren

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@rexagod rexagod requested a review from sashadev-sky August 16, 2019 14:57
@rexagod rexagod changed the title add dynamic-hotkeys functionality [WIP] add dynamic-hotkeys functionality Aug 17, 2019
Copy link
Member

@sashadev-sky sashadev-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rexagod very smart implementation!!! Thank you, i'm going to rebase this and then check if this can easily be applied to the collection group too. If it can, I will push that and merge this! If it can't, your call if you want to work on that here or merge and do it in a new PR. Either way will bump the version before merge.

@sashadev-sky sashadev-sky force-pushed the dyn-hk branch 2 times, most recently from bb0694c to 74916e3 Compare August 20, 2019 10:06
@sashadev-sky
Copy link
Member

@rexagod I did a bad job at rebasing your code formatting PR, so I am going to merge this because it address some of the updates I overrwrote.

The only part left to resolve is how to make this work for the collection group. If you have one image that has scale in its toolbar, for ex, but another that doesnt, how do you make scale available on only one of them?

@sashadev-sky sashadev-sky merged commit f846b13 into main Aug 20, 2019
sashadev-sky pushed a commit that referenced this pull request Sep 15, 2019
* add dynamic-hotkeys functionality

* nitpick

* build

* updates
themacboy pushed a commit to themacboy/Leaflet.DistortableImage that referenced this pull request Sep 19, 2019
* add dynamic-hotkeys functionality

* nitpick

* build

* updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hotkeys should only be available for present toolbar actions
2 participants