Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix #431

Merged
merged 22 commits into from
Sep 16, 2019
Merged

Hotfix #431

merged 22 commits into from
Sep 16, 2019

Conversation

sashadev-sky
Copy link
Member

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@sashadev-sky
Copy link
Member Author

@jywarren leaflet 0.8.0 published today has bug! Single image interface will break for lock, export or delete action. This PR not totally finished but fixes bug and can bee merged if you need to! This is making selections more clear by calling multi-selections "collections" and it makes bridge for mode API and toolbar with methods setMode() and nextMode() that can be called programmatically with or w/out tb

c

@sashadev-sky
Copy link
Member Author

Ok im just going to publish so that theres no bug anymore! Just moved things around here and wrote a few more tests its not a big change as it looks like

@sashadev-sky sashadev-sky merged commit 22cf322 into publiclab:main Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant