-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refact:disable dragging #585
Conversation
Thanks for opening this pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome thank you!!! Just one thing and then we're ready to merge - this is something we need to update from our end but if you check git status
in your console you'll see that the dist/leaflet.distortableimage.js
file has been updated again, commit this version to your branch (it wont say 14,000 changes anymore)
@sashadev-sky done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thank you! Merging this now.
I ended up re-commiting the dist
for you because it was still the one with 14,000 changes. But don't sweat it that's something we need to fix on our end.
Congrats on merging your first pull request! 🙌🎉⚡️ |
* refact:disable dragging * fix: commit fix * Commit dist * recommit dist Co-authored-by: Prince Verma <[email protected]> Co-authored-by: sashadev-sky <[email protected]>
* refact:disable dragging * fix: commit fix * Commit dist * recommit dist Co-authored-by: Prince Verma <[email protected]> Co-authored-by: sashadev-sky <[email protected]>
Fixes #584 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt
If tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
@sashadev-sky
Thanks!