Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact:disable dragging #585

Merged
merged 4 commits into from
Apr 5, 2020
Merged

Conversation

prncvrm
Copy link
Contributor

@prncvrm prncvrm commented Apr 4, 2020

Fixes #584 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
@sashadev-sky
Thanks!

@welcome
Copy link

welcome bot commented Apr 4, 2020

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

Copy link
Member

@sashadev-sky sashadev-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thank you!!! Just one thing and then we're ready to merge - this is something we need to update from our end but if you check git status in your console you'll see that the dist/leaflet.distortableimage.js file has been updated again, commit this version to your branch (it wont say 14,000 changes anymore)

@prncvrm
Copy link
Contributor Author

prncvrm commented Apr 5, 2020

@sashadev-sky done

@sashadev-sky sashadev-sky self-requested a review April 5, 2020 10:27
Copy link
Member

@sashadev-sky sashadev-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thank you! Merging this now.

I ended up re-commiting the dist for you because it was still the one with 14,000 changes. But don't sweat it that's something we need to fix on our end.

@sashadev-sky sashadev-sky merged commit 7f75675 into publiclab:main Apr 5, 2020
@welcome
Copy link

welcome bot commented Apr 5, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

sashadev-sky added a commit that referenced this pull request Apr 13, 2020
* refact:disable dragging

* fix: commit fix

* Commit dist

* recommit dist

Co-authored-by: Prince Verma <[email protected]>
Co-authored-by: sashadev-sky <[email protected]>
sashadev-sky added a commit to carlo-ev/Leaflet.DistortableImage that referenced this pull request Apr 14, 2020
* refact:disable dragging

* fix: commit fix

* Commit dist

* recommit dist

Co-authored-by: Prince Verma <[email protected]>
Co-authored-by: sashadev-sky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encapsulate disable dragging functionality into '#_disableDragging`
2 participants