Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try setting up gitpod for building for each PR to ease reviewing #680

Merged
merged 2 commits into from
Jul 25, 2020
Merged

Try setting up gitpod for building for each PR to ease reviewing #680

merged 2 commits into from
Jul 25, 2020

Conversation

jywarren
Copy link
Member

@jywarren jywarren commented Jul 5, 2020 •
edited
Loading

Building on example at publiclab/image-sequencer#1668

cc @sashadev-sky take a look - gitpod can build a full hosted version for each PR!

jywarren
jywarren commented Jul 5, 2020
View reviewed changes
.gitpod.yml
@@ -0,0 +1,17 @@
tasks:
- init: npm i && npm run build
command: npm run serve:dev
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at https://github.com/publiclab/Leaflet.DistortableImage/blob/main/package.json, to configure

@jywarren jywarren closed this Jul 5, 2020
@jywarren jywarren reopened this Jul 5, 2020
@jywarren jywarren closed this Jul 5, 2020
@jywarren jywarren reopened this Jul 5, 2020
@gitpod-io
Copy link

gitpod-io bot commented Jul 5, 2020 •
edited
Loading

@jywarren
Copy link
Member Author

jywarren commented Jul 5, 2020 •
edited
Loading

Hmm! Test error, probably due to setup, and Travis I think caught it too. But, it did seem to be trying to serve the app in GitPod! So if we can get the settings right perhaps this will work!

I think it's not properly installing Leaflet...

05 07 2020 22:06:22.173:WARN [filelist]: Pattern "/workspace/Leaflet.DistortableImage/node_modules/leaflet/dist/leaflet-src.js" does not match any file.
05 07 2020 22:06:22.176:WARN [filelist]: Pattern "/workspace/Leaflet.DistortableImage/node_modules/leaflet/dist/leaflet.css" does not match any file.

...

✔ 0 tests completed
PhantomJS 2.1.1 (Linux x86_64) ERROR
  ReferenceError: Can't find variable: L
  at /workspace/Leaflet.DistortableImage/src/util/DomUtil.js:1:2 <- src/util/DomUtil.es5.js:1:4011

@jywarren jywarren mentioned this pull request Jul 5, 2020
Open
5 tasks
@jywarren jywarren changed the title Try setting up gitpod Try setting up gitpod for building for each PR to ease reviewing Jul 5, 2020
@jywarren jywarren mentioned this pull request Jul 5, 2020
Closed
@jywarren
Copy link
Member Author

jywarren commented Jul 5, 2020

Hmm. Still seeing the timeout issue and have documented it in #681. If we can resolve that, i believe this will start working!

@jywarren jywarren mentioned this pull request Jul 7, 2020
Closed
@sashadev-sky
Copy link
Member

@jywarren i followed the PR trail and saw we never resolved this. Restarting the build one or two (maybe 3?) times results in a pass so for now I guess that's what we'd have to do. We can merge this if it's ready!

@sashadev-sky
Copy link
Member

Merging as tests are passing :) @jywarren

@sashadev-sky sashadev-sky merged commit 40b2818 into main Jul 25, 2020
@jywarren
Copy link
Member Author

This is great, Sasha!!!!! Now it can be tested interactively on the fly in each PR. Thanks!!!

This was referenced Sep 15, 2020
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jywarren @sashadev-sky