Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-587: update trigUtil method syntax to ES6 #726

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

javed24
Copy link
Contributor

@javed24 javed24 commented Aug 26, 2020

Fixes #587

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Aug 26, 2020

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented Aug 26, 2020

@javed24
Copy link
Contributor Author

javed24 commented Aug 26, 2020

@sashadev-sky this is the PR for issue #587. Let me know if it looks good, thanks! 👍

Copy link
Member

@sashadev-sky sashadev-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javed24 perfect thank you!!

Would you mind just putting the extra spacing back in the ternary operator please? I think we always use 4 space indent for multi-line ternaries

Also just a tip don't need to update this - the PR title doesn't need to reference the original issue, that is what we link it in the PR body (Fixes #<issue_number>) for

putting back extra spaces
@javed24
Copy link
Contributor Author

javed24 commented Aug 26, 2020

@javed24 perfect thank you!!

Would you mind just putting the extra spacing back in the ternary operator please? I think we always use 4 space indent for multi-line ternaries

updated! 👍

Also just a tip don't need to update this - the PR title doesn't need to reference the original issue, that is what we link it in the PR body (Fixes #<issue_number>) for

understood, thanks!

Copy link
Member

@sashadev-sky sashadev-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javed24 thank you! Good to go

@sashadev-sky sashadev-sky merged commit 5582931 into publiclab:main Aug 26, 2020
@welcome
Copy link

welcome bot commented Aug 26, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://mapknitter.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update L.TrigUtil method creation to ES6 syntax
2 participants