-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue-587: update trigUtil method syntax to ES6 #726
Issue-587: update trigUtil method syntax to ES6 #726
Conversation
Thanks for opening this pull request! |
@sashadev-sky this is the PR for issue #587. Let me know if it looks good, thanks! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javed24 perfect thank you!!
Would you mind just putting the extra spacing back in the ternary operator please? I think we always use 4 space indent for multi-line ternaries
Also just a tip don't need to update this - the PR title doesn't need to reference the original issue, that is what we link it in the PR body (Fixes #<issue_number>
) for
putting back extra spaces
updated! 👍
understood, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javed24 thank you! Good to go
Congrats on merging your first pull request! 🙌🎉⚡️ |
Fixes #587
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
grunt test
If tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!