Adding a feature that takes width and height in percentage values. #353
Comments
|
GitMate.io thinks the contributor most likely able to help you is @jywarren. A possibly related issue is #205 (add "drag to crop" UI feature to Crop module). |
1 similar comment
|
GitMate.io thinks the contributor most likely able to help you is @jywarren. A possibly related issue is #205 (add "drag to crop" UI feature to Crop module). |
|
Awesome!!
…On Fri, Sep 28, 2018, 11:08 PM gitmate[bot] ***@***.***> wrote:
GitMate.io <https://gitmate.io> thinks the contributor most likely able
to help you is @jywarren <https://github.com/jywarren>.
A possibly related issue is #205
<#205> (add "drag to
crop" UI feature to Crop module).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#353 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJycm6mxq8Imsi1USfghksA1GQmtjks5ufwAVgaJpZM4XAVQL>
.
|
|
Aren't the also x and y fields? Would we want to allow percentage or
integer in any field?
…On Sat, Sep 29, 2018, 7:16 AM Varun Gupta ***@***.***> wrote:
@jywarren <https://github.com/jywarren>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#353 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ_kwJAvo3-5GEoQSO3OIDJjZ_trFks5uf3KEgaJpZM4XAVQL>
.
|
|
Hmm, I would have to think this through, this seems a little tricky to me! |
|
I mean the whole point of using % is so users do not have to tinker around with exact positions, so just implementing this in height and width wouldn't cut it, what do you think @jywarren ? |
|
The defaults can be 0,0 for sure, I'm just thinking to leave the
opportunity for more specifics open for people who want them... How's that?
Thanks!
…On Sat, Sep 29, 2018, 7:22 AM Varun Gupta ***@***.***> wrote:
I mean the whole point of using % is so users do not have to tinker around
with exact positions, so just implementing this in height and width
wouldn't cut it, what do you think @jywarren <https://github.com/jywarren>
?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#353 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJyw7YZKuWl08bburrle0iu-nl61kks5uf3QIgaJpZM4XAVQL>
.
|
|
Hmm, I think maybe we can allow % in all fields and then someone can clip the image from 30% to 60% |
|
I think the best way to do this is to define a function on sequencer itself which parses the input and if it is in % then it picks up the output and generates coordinates from that, what say? |
|
Ok!
…On Sat, Sep 29, 2018, 7:29 AM Varun Gupta ***@***.***> wrote:
Hmm, I think maybe we can allow % in all fields and then someone can clip
the image from 30% to 60%
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#353 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ-E08r28EsSptX6i9P7zHh3L6Luuks5uf3WhgaJpZM4XAVQL>
.
|
|
something like |
|
Great!!
…On Sat, Sep 29, 2018, 7:31 AM Varun Gupta ***@***.***> wrote:
something like sequencer.parseCoordinates(input)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#353 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ121z5PV21MgRqmSPj_kEUmqeIPLks5uf3YogaJpZM4XAVQL>
.
|
|
The default for width and height is 100%, so from there I got this idea. This will not be okay for x and y fields as they are coordinates with (0,0). |
|
@Paarmita The idea here is to have a function through which we pipe the inputs and it generates the coordinates based on image dimensions, you are right the default value for (x,y) is (0,0) but someone might want to clip the image from 20% to 50%. So let's create a function which can be used across all modules which deal with coordinates(like overlay). |
|
Can I work on this issue? |
|
@Divy123 Yes, You can as no one is currently working on it. |
|
@Paarmita can you please guide me on how to start with this? |
|
I think that's right -- perhaps we can detect if the input ends in a %, and
parse only if it does. And keep in mind inputs might be one in percentage,
the other in units, so that we'll need to decide to parse them on a
case-by-case basis?
…On Tue, Nov 13, 2018 at 12:09 PM Slytherin ***@***.***> wrote:
@Paarmita <https://github.com/Paarmita> can you please guide me on how to
start with this?
I was looking through the discussion above and concluded that we require a
function that takes the input ,parses it and converts to the coordinates.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#353 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ9MSicP9GRmgDzLmXelIdjpOnsh2ks5uuvy6gaJpZM4XAVQL>
.
|
|
@tech4GT I would like to work on this issue! |
|
I am currently working on it. |
|
Yes, sure! @Divy123 |
We could add a feature in the input that can also take integer values other than an integer.
File to be changed
https://github.com/publiclab/image-sequencer/blob/main/src/modules/Crop/Ui.js#L75
The text was updated successfully, but these errors were encountered: