Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resize module to list of quick buttons #499

Closed
3 tasks
jonxuxu opened this issue Nov 26, 2018 · 11 comments
Closed
3 tasks

Add resize module to list of quick buttons #499

jonxuxu opened this issue Nov 26, 2018 · 11 comments

Comments

@jonxuxu
Copy link
Member

jonxuxu commented Nov 26, 2018

This issue is a sub-issue of #487 , which is to be broken down into smaller issues.

In the image-sequencer, there are a list of quick-buttons so the user can add commonly-used layers quickly:
image

What we want to do is to add another quick-add button for the resize functionality. Here's the todo for this task:

  • Find a suitable icon on font-awesome and link it here make sure it's from the v4.5 icon set!
  • Add the icon in the appropriate button style in examples/index.html.
    image
  • Keep in mind the proper syntax for data-value, which can be checked by navigating to the proper component in src/modules. It is lowercase

Please show us where to look

http://sequencer.publiclab.org/examples/#steps=

What's your PublicLab.org username?

JonathanXu1

Browser, version, and operating system

Firefox63, Windows 10


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@gitmate
Copy link

gitmate bot commented Nov 26, 2018

GitMate.io thinks the contributors most likely able to help are @oorjitchowdhary, and @WELCOME[bot].

Possibly related issues are #492 (Add the Resize module to the quick buttons bar), #432 (display add step menu with common modules as "quick" buttons), #433 (display add step menu with common modules as "quick" buttons), #27 (add fisheyegl module), and #138 (Add a Dithering module).

1 similar comment
@gitmate
Copy link

gitmate bot commented Nov 26, 2018

GitMate.io thinks the contributors most likely able to help are @oorjitchowdhary, and @WELCOME[bot].

Possibly related issues are #492 (Add the Resize module to the quick buttons bar), #432 (display add step menu with common modules as "quick" buttons), #433 (display add step menu with common modules as "quick" buttons), #27 (add fisheyegl module), and #138 (Add a Dithering module).

@gitmate gitmate bot added the enhancement label Nov 26, 2018
@jywarren
Copy link
Member

jywarren commented Nov 26, 2018 via email

@harshithpabbati
Copy link

Was this a open issue?? Can i work on it??

@harshkhandeparkar
Copy link
Member

Go ahead @harshithpabbati

@harshithpabbati
Copy link

resize
@harshkhandeparkar I am almost done with it.But i cant get the image on the resize module.Can you help me out??

@harshkhandeparkar
Copy link
Member

@Hashithpabbati you will have to use some fontawesome icon. Choose an appropriate icon from here

@harshkhandeparkar
Copy link
Member

Oh wait, the image you provided didn't load for me. Sorry, I though you were asking something else. Can you please open a pr or give me a link to your branch? Btw you have to change the examples/lib/intermediateHtmlStepUi.js file too. @harshithpabbati

@harshithpabbati
Copy link

harshithpabbati commented Feb 16, 2019

Oh wait, the image you provided didn't load for me. Sorry, I though you were asking something else. Can you please open a pr or give me a link to your branch? Btw you have to change the examples/lib/intermediateHtmlStepUi.js file too. @harshithpabbati

Yeah i made the change in the intermediateHtmlStepUi.js
I used the font-awesome icon though i couldn't get the icon

@harshkhandeparkar
Copy link
Member

Are you going to open a PR? Or atleast provide me a link to the branch so that I can help you in troubleshooting.

@harshithpabbati
Copy link

fine i will open the pr jst wait a min

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants