Add "(local)" to locally stored modules

[jywarren]

It's possible to save a sequence locally, and have it appear in the Add Step menu (see #587). Let's be sure any we add there are marked with (local) in their name so people know which are locally stored an which are built-in.

[gitmate]

GitMate.io thinks possibly related issues are #205 (add "drag to crop" UI feature to Crop module), #569 (add toggle-able collapse button for modules ), #157 (Add a Contrast module), #158 (Add a Saturation Module), and #369 (Add a Grayscale module).

[gitmate]

GitMate.io thinks possibly related issues are #205 (add "drag to crop" UI feature to Crop module), #569 (add toggle-able collapse button for modules ), #157 (Add a Contrast module), #158 (Add a Saturation Module), and #369 (Add a Grayscale module).

[vibhorgupta-gh]

@jywarren I'd like to work on this. I understand the part where it'll be better to label the locally saved steps in the sequence (local). I reckon when the user clears cache or reloads the application and sees the saved sequence, it should display a (local) to demark it as already saved in the browser, and any steps added further after which are not saved should not show the (local) mark right?
The part I don't understand is, what do you mean by built-in ?

[Mridul97]

I think this issue has an easy fix, when a user enters the name of the sequence to be saved, we can append '(local)' to the name, so now the sequence will be saved as 'userGivenName (local)' This can be done before calling 'sequencer.saveSequence()' function!

[Mridul97]

Something like this:

[vibhorgupta-gh]

@Mridul97 Or instead of displaying (local) in the drop-down, we can append it to the title of the step, probably a side text or something.
For example, I save a sequence with two steps, reload the page, and it shows (local) in front of the two steps that I saved. All the subsequent steps added, before saving the next sequence, will not have the (local) tag. Will post a screenshot once I reach home or better understanding

[jywarren]

Ah, i see. we would yes probably need to not just save it in the dropdown, but "upstream" as it's stored in localstorage, which would then be reflected in the dropdown, right? This would be great!

…

On Wed, Jan 2, 2019 at 9:31 AM Vibhor Gupta ***@***.***> wrote: @Mridul97 <https://github.com/Mridul97> Or instead of displaying (local) in the drop-down, we can append it to the title of the step, probably a side text or something. For example, I save a sequence with two steps, reload the page, and it shows (local) in front of the two steps that I saved. All the subsequent steps added, before saving the next sequence, will not have the (local) tag. Will post a screenshot once I reach home or better understanding — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#591 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJwA5PD9fSwJd7ZAwussWF6PZcD8xks5u_MKHgaJpZM4ZmLtt> .

[Mridul97]

Yes, It would be stored in the local storage by the name "userGivenName (local)" and that would then appear in the dropdown!

Please see here #596 I have implemented this!

[jywarren]

Oh hi @VibhorCodecianGupta -- sorry I merged @Mridul97 's solution but we'd love your help with other issues. It's so great to have a community of collaboration on this library - it's moving so fast!!!

[vibhorgupta-gh]

@jywarren haha no worries! One way or the other, contributions matter!