Added Face detection Module #1597
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@publiclab/is-reviewers |
|
@ataata107 why are the tests failing? |
rishabhshuklax
requested changes
Jan 30, 2020
| color = 'rgba(20,20,20,1)'; | ||
| color = color.substring(color.indexOf('(') + 1, color.length - 1); // Extract only the values from rgba(_,_,_,_) | ||
| color = color.split(','); | ||
| fetch(cascadeurl).then(function(response) { |
There was a problem hiding this comment.
Maybe because of this the tests are failing, also does it work in node?
You could either install fetch for node from npm or use axios.
why is this used anyways?
There was a problem hiding this comment.
Ya this could be the reason, I will try to fetch it locally rather than from internet. It is used to fetch the trained model file which would be used to infer the face location
|
|
Codecov Report
@@ Coverage Diff @@
## main #1597 +/- ##
===========================================
+ Coverage 55.11% 65.21% +10.09%
===========================================
Files 117 134 +17
Lines 2344 2757 +413
Branches 360 438 +78
===========================================
+ Hits 1292 1798 +506
+ Misses 1052 959 -93
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
This Module doesn't make the use of opencv as discussed
npm run test-all@publiclab/is-reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!