Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix remove step UI #288

Merged
merged 2 commits into from
Jun 8, 2018
Merged

fix remove step UI #288

merged 2 commits into from
Jun 8, 2018

Conversation

tech4GT
Copy link
Member

@tech4GT tech4GT commented Jun 8, 2018

Signed-off-by: tech4GT [email protected]

Signed-off-by: tech4GT <[email protected]>
@ghost ghost assigned tech4GT Jun 8, 2018
@ghost ghost added the in-progress label Jun 8, 2018
@tech4GT
Copy link
Member Author

tech4GT commented Jun 8, 2018

fixes #286

@tech4GT
Copy link
Member Author

tech4GT commented Jun 8, 2018

@jywarren my bad!! I ran only on the last step in removeStep also!! fixed it!!

@tech4GT tech4GT requested a review from jywarren June 8, 2018 19:05
@jywarren
Copy link
Member

jywarren commented Jun 8, 2018

Can you bump version number to 2.0.1? Thanks!!!

@tech4GT
Copy link
Member Author

tech4GT commented Jun 8, 2018

@jywarren bumping version!!

@tech4GT
Copy link
Member Author

tech4GT commented Jun 8, 2018

@jywarren Done!!

@tech4GT
Copy link
Member Author

tech4GT commented Jun 8, 2018

@jywarren nice catch btw!! Thanks a lot!!

@tech4GT
Copy link
Member Author

tech4GT commented Jun 8, 2018

@jywarren travis is behaving weirdly here!! apt-get is failing

@jywarren
Copy link
Member

jywarren commented Jun 8, 2018

Try closing and reopening?

@tech4GT tech4GT closed this Jun 8, 2018
@ghost ghost removed the in-progress label Jun 8, 2018
@tech4GT tech4GT reopened this Jun 8, 2018
@ghost ghost added the in-progress label Jun 8, 2018
@tech4GT
Copy link
Member Author

tech4GT commented Jun 8, 2018

@jywarren this finally works!!!

@tech4GT
Copy link
Member Author

tech4GT commented Jun 8, 2018

Awesome!!!

@jywarren jywarren merged commit f431515 into publiclab:master Jun 8, 2018
@ghost ghost removed the in-progress label Jun 8, 2018
@jywarren
Copy link
Member

jywarren commented Jun 8, 2018

Oops - not a big deal, but for bugfixes, you can put v0.0.x level fixes. v0.x.0 means a new feature added!

@tech4GT
Copy link
Member Author

tech4GT commented Jun 8, 2018

oh should I change that @jywarren or do that in the future?

@jywarren
Copy link
Member

jywarren commented Jun 8, 2018 via email

@tech4GT
Copy link
Member Author

tech4GT commented Jun 8, 2018

Sure thing @jywarren Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants