Html type in info files

[harshkhandeparkar]

Fixes #570

Added separate property htmlType to info.json files to make the type property more specific.

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[harshkhandeparkar]

@jywarren I fixed the issues with the last PR and the tests pass locally.

DOCS:
https://github.com/HarshKhandeparkar/image-sequencer/blob/htmlType-in-info-files/CONTRIBUTING.md#info-file

[harshkhandeparkar]

The CI tests pass!! 🎉

[harshkhandeparkar]

@jywarren @tech4GT please review this.

[harshkhandeparkar]

@publiclab/is-reviewers please review this.

[harshkhandeparkar]

@Mridul97 @VibhorCodecianGupta can you guys please review this?

[harshkhandeparkar]

@jywarren

[dojutsu-user]

@harshkhandeparkar
Please be patient as this is not the only PR to be reviewed by the team. https://github.com/publiclab/image-sequencer/pulls

[harshkhandeparkar]

@dojutsu-user are you an old contributor?

[harshkhandeparkar]

Or a reviewer for some other project like plots?

[dojutsu-user]

@harshkhandeparkar
I am just another open-source enthusiast and full-stack developer who WAS looking to contribute towards this organisation but seeing this kind of behaviour as seen above, I feel regretful to change my decision.

Seems like all the V. Guptas contribute to image-sequencer

Also, this is not a social media paltform, this is a PR. I request @jywarren @tech4GT to please look into this rude and insignificant behaviour.

Also tagging @VibhorCodecianGupta to bring this comment to his notice.

[harshkhandeparkar]

@dojutsu-user I was a bit impatient as I am going to be busy for the next 2 years and I have only 1 month time window before I stop doing anything. Sorry if you felt that I was rude. My apologies 😣😣

[harshkhandeparkar]

To me, that was just a friendly comment. I was really happy to see this community grow. I am really sorry if it hurt anybody's feelings. I didn't mean to do that.

[harshkhandeparkar]

Please contribute to image sequencer. Don't feel hurt by my comments. We would like to have your help. Welcome to the image sequencer community. I am just a GCI student btw

[harshkhandeparkar]

@dojutsu-user I accept my mistake that I went a bit personal with you people's names but I did that in a friendly manner not to hurt anybody.

[harshkhandeparkar]

Also the first question that i asked

Who are an old contributor?

That was a typo. I meant to ask if you were an old contributor. I have updated that comment now.

[dojutsu-user]

@harshkhandeparkar
I am not an old contributor of publiclab.

[harshkhandeparkar]

Thanks @gauravano for adding that label

[grvsachdeva]

Hi @harshkhandeparkar, the comments written by you in this thread were bad and violates PublicLab's Code of conduct - http://publiclab.org/conduct.

We appreciate your contributions to Public Lab's projects but at the same time the behaviour shown by you towards other contributors should be respectful and should follow our Code of conduct at all times.

Hi @dojutsu-user, we are apologetic for the @harshkhandeparkar's behaviour and comments, and feel sorry that you have a bad experience in your Open Source journey with us. We hope that you will forgive him and will continue to contribute to the Public Lab.

Regards,
Gaurav Sachdeva

cc @jywarren @publiclab/community-reps

[harshkhandeparkar]

@gauravano @jywarren @tech4GT @VibhorCodecianGupta @dojutsu-user sorry. my apologies I have accepted my mistake. Please forgive me.

[harshkhandeparkar]

@jywarren @gauravano based on @dojutsu-user's first comment, I thought that he might be an old contributor or a reviewer whom I haven't met before so I wanted to ask him that question but while I was typing the question, I reframed it once but while doing that I made a typo.

Istead of writing

Are you an old contributor?

I wrote

Who are an old contributor?

This question kind of seems like a rhetorical one even though it was not meant to be. This might have created a misunderstanding and the comment might have looked a little rude to @dojutsu-user. As for the second comment about contributors, I accept my mistake and I have apologised already. Sorry, I will not repeat such behaviour again and think twice before commenting. 😞😞😞😞

[jywarren]

Hello all - I apologize for not commenting earlier. I agree with @gauravano that this was regrettable and @dojutsu-user thank you for bringing this to our attention. @harshkhandeparkar your apology is appreciated and I'll just add that we can all experience moments of impatience or frustration, but taking a moment to consider before replying is often a good habit in these moments.

@dojutsu-user (and anyone else as well), please feel free to reach out to [email protected] if you feel you'd like to discuss this further off this thread.

Thank you for upholding our Code of Conduct and I hope we can build a constructive way forward from here.

[harshkhandeparkar]

I don't think this is needed anymore due to changes suggested in #570 (comment)