Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capybara wait time on tests #7568

Merged
merged 4 commits into from
Feb 28, 2020
Merged

Add capybara wait time on tests #7568

merged 4 commits into from
Feb 28, 2020

Conversation

cesswairimu
Copy link
Collaborator

This is causing a bunch of PRs to fail on travis

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #7568 into master will increase coverage by 1.83%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7568      +/-   ##
==========================================
+ Coverage   80.07%   81.90%   +1.83%     
==========================================
  Files          97       97              
  Lines        5635     5615      -20     
==========================================
+ Hits         4512     4599      +87     
+ Misses       1123     1016     -107     
Impacted Files Coverage Δ
app/models/node.rb 90.90% <0.00%> (+0.37%) ⬆️
app/api/srch/search.rb 65.35% <0.00%> (+0.65%) ⬆️
app/controllers/users_controller.rb 82.29% <0.00%> (+1.04%) ⬆️
app/helpers/application_helper.rb 84.52% <0.00%> (+1.19%) ⬆️
app/controllers/search_controller.rb 97.67% <0.00%> (+2.32%) ⬆️
app/controllers/wiki_controller.rb 85.00% <0.00%> (+3.07%) ⬆️
app/models/concerns/node_shared.rb 90.29% <0.00%> (+3.39%) ⬆️
app/models/tag_selection.rb 96.00% <0.00%> (+4.00%) ⬆️
app/controllers/tag_controller.rb 80.49% <0.00%> (+5.57%) ⬆️
app/controllers/questions_controller.rb 90.78% <0.00%> (+9.21%) ⬆️
... and 6 more

This is causing a bunch of PRs to fail on travis
@alaxalves
Copy link
Member

alaxalves commented Feb 27, 2020

@cesswairimu Let's get this Travis thing to run "locally", what do you think?? I'm Mapknitter we got the tests to run ~2x faster. Let me work with that on top of this branch?

We set the jobs to properly run in parallel, include a stage where can remain testing the docker building, including some gem caching....

Link for the MK changes: publiclab/mapknitter#672

@cesswairimu cesswairimu requested a review from a team as a code owner February 27, 2020 21:59
@alaxalves alaxalves force-pushed the fix-travis-issues branch 22 times, most recently from a11d191 to 635a0e4 Compare February 28, 2020 05:00
@alaxalves alaxalves force-pushed the fix-travis-issues branch 2 times, most recently from 5ebb12c to 313ea3a Compare February 28, 2020 05:16
@cesswairimu
Copy link
Collaborator Author

Thats so much @alaxalves this is superb 🚀

Copy link
Member

@SidharthBansal SidharthBansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@cesswairimu cesswairimu merged commit 4e6eddb into master Feb 28, 2020
@alaxalves alaxalves deleted the fix-travis-issues branch February 28, 2020 18:17
icarito pushed a commit that referenced this pull request Mar 31, 2020
* add capybara wait time on tests

This is causing a bunch of PRs to fail on travis

* remove ajax wait time

* Using local builds for Travis

* reduce wait time back to original time

Co-authored-by: Álax de Carvalho Alves <[email protected]>
@jywarren jywarren mentioned this pull request Aug 18, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants