-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add capybara wait time on tests #7568
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7568 +/- ##
==========================================
+ Coverage 80.07% 81.90% +1.83%
==========================================
Files 97 97
Lines 5635 5615 -20
==========================================
+ Hits 4512 4599 +87
+ Misses 1123 1016 -107
|
This is causing a bunch of PRs to fail on travis
291a607
to
d1a77d2
Compare
@cesswairimu Let's get this Travis thing to run "locally", what do you think?? I'm Mapknitter we got the tests to run ~2x faster. Let me work with that on top of this branch? We set the jobs to properly run in parallel, include a stage where can remain testing the docker building, including some gem caching.... Link for the MK changes: publiclab/mapknitter#672 |
9480c75
to
c641fed
Compare
a11d191
to
635a0e4
Compare
5ebb12c
to
313ea3a
Compare
313ea3a
to
fbf161d
Compare
b5e27b1
to
6625b58
Compare
Thats so much @alaxalves this is superb 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
* add capybara wait time on tests This is causing a bunch of PRs to fail on travis * remove ajax wait time * Using local builds for Travis * reduce wait time back to original time Co-authored-by: Álax de Carvalho Alves <[email protected]>
This is causing a bunch of PRs to fail on travis
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!