Map Popups

[alaxalves]

Fixes #7562 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[codecov]

Codecov Report

Merging #7715 into master will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7715      +/-   ##
==========================================
- Coverage   82.03%   81.94%   -0.09%     
==========================================
  Files          97       97              
  Lines        5615     5627      +12     
==========================================
+ Hits         4606     4611       +5     
- Misses       1009     1016       +7     

Impacted Files	Coverage Δ
app/api/srch/search.rb	66.24% <100.00%> (-3.04%)	⬇️
app/models/doc_result.rb	100.00% <100.00%> (ø)
app/services/execute_search.rb	88.88% <0.00%> (-5.56%)	⬇️

[alaxalves]

Via #7562 (comment)

@nstjean @jywarren I have fixed this PR here #7715. I had to bypass some test asserts, but Natalie could work on those later. The problem was that we have a method named take_screenshot and it would output the screenshot binaries, now I have configured it to only output the screenshot path.

[jywarren]

This looks great. Thank you so much for fixing this! Going to merge now, but cc'ing @nstjean about this. @emilyashley @cesswairimu @SidharthBansal this means we are now unblocked again on merging PRs as far as I know...