Use read only mode for database maintenance windows

closes #2648

app/controllers/account_controller.rb

@@ -5,16 +5,12 @@
 class AccountController < ApplicationController
   include ApplicationHelper
 
+  before_action :read_only_redirect
   before_action :require_user_authentication_provider
   before_action :verify_user, except: [:borrow_direct_redirect]
 
   def index
-    if Orangelight.read_only_mode
-      msg = "Account page is disabled. #{Orangelight.read_only_message}"
-      redirect_to root_path, flash: { notice: msg }
-    else
-      redirect_to digitization_requests_path
-    end
+    redirect_to digitization_requests_path
   end
 
   def digitization_requests
@@ -42,6 +38,13 @@ def cancel_ill_requests
 
   protected
 
+    def read_only_redirect
+      if Orangelight.read_only_mode
+        flash[:notice] = 'Account login unavailable during maintenace.'
+        redirect_to(root_url) && return
+      end
+    end
+
     def verify_user
       unless current_user
         flash[:error] = I18n.t('blacklight.saved_searches.need_login') &&

app/views/account/_login_links.html.erb

@@ -1,7 +1,11 @@
 <% if !current_user %>
   <div class='card'>
     <div class='card-body'>
-      To view previously saved <%= feature_page %>, please <%= link_to "log in", main_app.new_user_session_path(origin: request.fullpath) %> to your catalog account.
+      <% if Orangelight.read_only_mode %>
+        Previously saved <%= feature_page %> unavailable during maintenance.
+      <% else %>
+        To view previously saved <%= feature_page %>, please <%= link_to "log in", main_app.new_user_session_path(origin: request.fullpath) %> to your catalog account.
+      <% end %>
     </div>
   </div>
 <% end %>

config/initializers/read_only_mode.rb

@@ -6,9 +6,22 @@ def read_only_mode
   end
 
   def read_only_message
-    default_msg = "Catalog is in read-only mode."
+    default_msg = "The Library Catalog is undergoing maintenance. Bookmarks, digitization requests, and saved searches are currently unavailable."
     @read_only_message ||= ENV.fetch("OL_READ_ONLY_MESSAGE", default_msg)
   end
 
   module_function :read_only_mode, :read_only_message
 end
+
+# Block database writes in read_only mode
+if Orangelight.read_only_mode
+  class ActiveRecord::Base
+    before_save do
+      raise ActiveRecord::Rollback, "Read-only"
+    end
+
+    before_destroy do
+      raise ActiveRecord::Rollback, "Read-only"
+    end
+  end
+end

spec/controllers/account_controller_spec.rb

@@ -24,19 +24,16 @@
       .to_return(status: 200, body: verify_user_response)
   end
 
-  describe '#index' do
+  describe '#digitization_requests' do
     context 'when Orangelight is in read only mode' do
-      let(:valid_user) { FactoryBot.create(:valid_princeton_patron) }
-
       before do
-        sign_in(valid_user)
         allow(Orangelight).to receive(:read_only_mode).and_return(true)
       end
 
       it 'redirects to root and flashes an explanatory message' do
-        get :index
+        get :digitization_requests
         expect(response).to redirect_to(root_path)
-        expect(flash[:notice]).to include("Account page is disabled", "read-only")
+        expect(flash[:notice]).to include("Account login unavailable during maintenace.")
       end
     end
   end

spec/features/bookmarks_spec.rb

@@ -26,6 +26,17 @@
     end
   end
 
+  context 'when orangelight is in readonly mode' do
+    it 'has a maintenance message' do
+      allow(Orangelight).to receive(:read_only_mode).and_return(true)
+      visit '/bookmarks'
+      within('#content') do
+        expect(page).not_to have_link("log in")
+        expect(page).to have_content("unavailable during maintenance")
+      end
+    end
+  end
+
   context 'when logged in' do
     let(:user) { FactoryBot.create(:user) }
 

spec/features/request_options_spec.rb

@@ -26,16 +26,6 @@
     end
   end
 
-  describe 'the request button when orangelight is in read-only mode', js: true do
-    it 'does display a request button' do
-      allow(Orangelight).to receive(:read_only_mode).and_return(true)
-      visit '/catalog/9618072'
-      using_wait_time 5 do
-        expect(page).to have_selector('td[data-requestable="true"]')
-      end
-    end
-  end
-
   describe 'Available status non-requestable location', js: true do
     before do
       visit '/catalog/9222024'