Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused methods from PhysicalHoldingsMarkupBuilder #2224

Closed
hackartisan opened this issue Sep 1, 2020 · 0 comments · Fixed by #2226
Closed

Remove unused methods from PhysicalHoldingsMarkupBuilder #2224

hackartisan opened this issue Sep 1, 2020 · 0 comments · Fixed by #2226

Comments

@hackartisan
Copy link
Member

These don't look like they're used anywhere.

def self.scsb_supervised_request_link
link_to('Reading Room Request',
"/requests/#{doc_id}?source=pulsearch",
title: 'Request to view in Reading Room',
class: 'request btn btn-xs btn-primary',
data: { toggle: 'tooltip' })
end
def self.scsb_request_link
link_to(request_label(location_rules),
"/requests/#{doc_id}?source=pulsearch",
title: request_tooltip(location_rules),
class: 'request btn btn-xs btn-primary',
data: { toggle: 'tooltip' })
end
def self.ils_request_link
link_to(request_label(location_rules),
"/requests/#{doc_id}?mfhd=#{holding_id}&source=pulsearch",
title: request_tooltip(location_rules),
class: 'request btn btn-xs btn-primary',
data: { toggle: 'tooltip' })
end
def self.request_link
link_to('Reading Room Request',
"/requests/#{doc_id}?mfhd=#{holding_id}&source=pulsearch",
title: 'Request to view in Reading Room',
class: 'request btn btn-xs btn-primary',
data: { toggle: 'tooltip' })
end

And half of them would error if they were used because they wouldn't know what location_rules meant, because it's not passed into those methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant