-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use custom Solr docker image and remove solr_wrapper #2609
Conversation
I am so, so excited about this. How does the docker image get built and pushed to docker hub? |
@tpendragon DockerHub used to watch your repos and rebuild automatically, but that's now a paid-only option. :( You have to do it manually, but it's easy:
|
@eliotjordan Can you add that documentation to ci-solr-docker? I wonder if someday we can make CircleCI build and push it on merge to master - not important for now, though. |
@tpendragon Added those instructions to the ci-solr-docker README. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the only concern I have is that now CI won't be testing the latest version of what's in pul_solr, since the files are committed. Do you have any worries there?
I don't. The schema doesn't change that often, and it's easy to pull in with a rake task. We do this in other projects, and it's never been a problem. |
See:
https://github.com/pulibrary/ci-solr-docker
https://hub.docker.com/repository/docker/pulibrary/ci-solr
https://hub.docker.com/repository/docker/pulibrary/orangelight-solr
Closes #2364