Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom Solr docker image and remove solr_wrapper #2609

Merged
merged 8 commits into from
Aug 4, 2021
Merged

Conversation

eliotjordan
Copy link
Member

  • Creates a custom Solr image that allows installation of CJKFoldingFilter and lucene-umich-solr-filters plugins and bundles a dummy authentication document.

See:
https://github.com/pulibrary/ci-solr-docker
https://hub.docker.com/repository/docker/pulibrary/ci-solr
https://hub.docker.com/repository/docker/pulibrary/orangelight-solr

  • Modernizes the CircleCI config and adds a separate rubocop job
  • Removes solr_wrapper dependency
  • Adds checked-in copy of solr configuration for convenience

Closes #2364

@tpendragon
Copy link
Contributor

I am so, so excited about this. How does the docker image get built and pushed to docker hub?

@eliotjordan
Copy link
Member Author

@tpendragon DockerHub used to watch your repos and rebuild automatically, but that's now a paid-only option. :( You have to do it manually, but it's easy:

cd solr/docker/
docker login # login to docker hub
docker build -t pulibrary/orangelight-solr:8.4 .
docker push pulibrary/orangelight-solr:8.4

@tpendragon
Copy link
Contributor

tpendragon commented Aug 3, 2021

@eliotjordan Can you add that documentation to ci-solr-docker? I wonder if someday we can make CircleCI build and push it on merge to master - not important for now, though.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.915% when pulling 75a79ac on 2364-solr into 1a5d4d3 on main.

@eliotjordan
Copy link
Member Author

@tpendragon Added those instructions to the ci-solr-docker README.

Copy link
Contributor

@tpendragon tpendragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the only concern I have is that now CI won't be testing the latest version of what's in pul_solr, since the files are committed. Do you have any worries there?

@eliotjordan
Copy link
Member Author

I don't. The schema doesn't change that often, and it's easy to pull in with a rake task. We do this in other projects, and it's never been a problem.

@tpendragon tpendragon merged commit 1fdf450 into main Aug 4, 2021
@tpendragon tpendragon deleted the 2364-solr branch August 4, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully enable lando and remove solr wrapper
3 participants