Loads Rails environment so that Rails.logger.error() is available #2641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackartisan
approved these changes
Aug 9, 2021
|
And yes we normally don't test rake tasks themselves. If there's enough logic in them we would pull out the logic into a function somewhere and test that function. |
christinach
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2639
Although the real error behind 2639 was a Solr error, the error reported by Honeybadger was because it crashed when it tried to log the error. This PR addresses only the error reported by Honeybadger (i.e. not the Solr error)
I did not add a test since the problem was the declaration of the Rake task, let me know if I should add a test for that kind of mis-declaration of a rake task.