Prevents error when search query ends with empty parenthesis #2642

hectorcorrea · 2021-08-09T16:47:16Z

coveralls · 2021-08-09T17:01:19Z

Coverage increased (+0.004%) to 96.959% when pulling a29bb43 on issue_1656_parslet into bb1f26c on main.

…ure why in some controllers, like on Bookmarks, it's a Hash, but that would be for another ticket)

hackartisan

This will remove any additional "()" within the string, also, if it has more than one? I can't think of a reason to keep them, though.

hectorcorrea · 2021-08-10T13:26:13Z

@hackartisan agreed on both accounts.

hectorcorrea added 2 commits August 9, 2021 12:46

Prevents error when search query ends with empty parenthesis

14d65ba

Rubocop made me do it

6b6ee77

Tweak the guard condition to make sure the q value is a String (not s…

a29bb43

…ure why in some controllers, like on Bookmarks, it's a Hash, but that would be for another ticket)

hackartisan reviewed Aug 10, 2021

View reviewed changes

hackartisan approved these changes Aug 10, 2021

View reviewed changes

hackartisan merged commit db13d87 into main Aug 10, 2021

hackartisan deleted the issue_1656_parslet branch August 10, 2021 19:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevents error when search query ends with empty parenthesis #2642

Prevents error when search query ends with empty parenthesis #2642

hectorcorrea commented Aug 9, 2021

coveralls commented Aug 9, 2021 •

edited

Loading

hackartisan left a comment

hectorcorrea commented Aug 10, 2021

Prevents error when search query ends with empty parenthesis #2642

Prevents error when search query ends with empty parenthesis #2642

Conversation

hectorcorrea commented Aug 9, 2021

coveralls commented Aug 9, 2021 • edited Loading

hackartisan left a comment

Choose a reason for hiding this comment

hectorcorrea commented Aug 10, 2021

coveralls commented Aug 9, 2021 •

edited

Loading