-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed umlaut #2677
Removed umlaut #2677
Conversation
1fa1a54
to
bbb3193
Compare
Thank you @XanderGardner ! |
some more code needs to be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@XanderGardner I looked again. Thank you for removing the spec and the other reference in the application helper. The spec is testing some methods that they are still in the code. Can you first remove the methods and see the spec failing and then remove the spec as well? The methods I'm referring to are in
orangelight/app/helpers/application_helper.rb
Lines 15 to 30 in 8998c32
def umlaut_services_fulltext(document) | |
services = '' | |
unless document.key? 'electronic_access_1display' | |
services << content_tag(:div, '', :id => 'full_text', :class => ['availability--online', 'availability_full-text', 'availability--panel_umlaut'], 'data-umlaut-full-text' => true) | |
end | |
services.html_safe | |
end | |
# Generate the markup for two <div> elements containing links to umlaut services | |
# @return [String] the markup | |
def umlaut_services | |
services = '' | |
services << content_tag(:div, '', :id => 'excerpts', :class => ['availability--excerpts', 'availability_excerpts', 'availability--panel_umlaut'], 'data-umlaut-services' => true) | |
services << content_tag(:div, '', :id => 'highlighted_link', :class => ['availability--highlighted', 'availability_highlighted-link', 'availability--panel_umlaut'], 'data-umlaut-services' => true) | |
services.html_safe | |
end |
bbb3193
to
34f98f6
Compare
34f98f6
to
2d49fa9
Compare
closes #2644
closes #2623