Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed umlaut #2677

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Removed umlaut #2677

merged 1 commit into from
Sep 22, 2021

Conversation

XanderGardner
Copy link
Contributor

closes #2644
closes #2623

@XanderGardner XanderGardner marked this pull request as draft August 20, 2021 20:35
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.06% when pulling bbb3193 on 2644-umlaut into 22c2ddc on main.

@XanderGardner XanderGardner marked this pull request as ready for review September 15, 2021 14:02
@pulbot pulbot temporarily deployed to qa September 16, 2021 15:24 Inactive
@christinach
Copy link
Member

Thank you @XanderGardner !

christinach
christinach previously approved these changes Sep 16, 2021
@christinach christinach dismissed their stale review September 16, 2021 15:39

some more code needs to be removed.

Copy link
Member

@christinach christinach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XanderGardner I looked again. Thank you for removing the spec and the other reference in the application helper. The spec is testing some methods that they are still in the code. Can you first remove the methods and see the spec failing and then remove the spec as well? The methods I'm referring to are in

def umlaut_services_fulltext(document)
services = ''
unless document.key? 'electronic_access_1display'
services << content_tag(:div, '', :id => 'full_text', :class => ['availability--online', 'availability_full-text', 'availability--panel_umlaut'], 'data-umlaut-full-text' => true)
end
services.html_safe
end
# Generate the markup for two <div> elements containing links to umlaut services
# @return [String] the markup
def umlaut_services
services = ''
services << content_tag(:div, '', :id => 'excerpts', :class => ['availability--excerpts', 'availability_excerpts', 'availability--panel_umlaut'], 'data-umlaut-services' => true)
services << content_tag(:div, '', :id => 'highlighted_link', :class => ['availability--highlighted', 'availability_highlighted-link', 'availability--panel_umlaut'], 'data-umlaut-services' => true)
services.html_safe
end
. Thank you again for taking the time to work on this issue.

@pulbot pulbot temporarily deployed to qa September 17, 2021 15:26 Inactive
@bess bess added the minor label Sep 22, 2021
@bess bess merged commit 37325bb into main Sep 22, 2021
@bess bess deleted the 2644-umlaut branch September 22, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove umlaut specs Remove umlaut_base: https://getit.princeton.edu from the requests.yml
5 participants