Availability display in Show page for CDL items

[hectorcorrea]

Display "Online" as the availability for items in CDL instead of "Unavailable". It also removes the Request button from the page. Fixes #2669

The only drawback with the current implementation is that the user will initially see the "Request" button next to each item, and after a few seconds (when the call to BibData/Alma comes back) the Request buttons will be removed. This is a known issue due to the slowness of the Alma API to return when we request this level of information (see #1616) and could be tackled separately.

Below are two screenshots showing the page before and after the change.

Before

After

[hectorcorrea]

@kevinreiss I removed the Request button in this case just like we did with reserves, but let me know if that is not what we want for this.

[christinach]

In the past we displayed for cdl item status: 'Reserved for digital lending'.

orangelight/app/javascript/orangelight/availability.es6

Line 22 in a1a8813

'On-site - in-transit discharged', 'Reserved for digital lending'];

orangelight/app/javascript/orangelight/availability.es6

Line 330 in a1a8813

if (availability_label_text === "Reserved for digital lending") {

@kevinreiss, @kelynch do we want to display this status again instead of 'Online'?

[kevinreiss]

I approve of making this change where if I understand it the user will never see a request button for these items at any point no matter how slow the extra availability checks take.

[hectorcorrea]

@kevinreiss The current implementation will initially show the Request button for a few seconds (4-5 seconds) like it does for Reserves and then, after Alma comes back with CDL info we hide them. This is not ideal.

We could try to implement this the other way around: Initially hide the Request button and only show if after the Alma slow API comes back. But this will be a more complicated and riskier change so I would vote to do that separately so that we can test it extensively...because if we mess that one up the Request button won't show up if there is an Alma error or bug in our code.