-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add separate enum for Tag ends #517
Merged
Martin1887
merged 16 commits into
pulldown-cmark:master
from
marcusklaas:close-tag-experiments
May 20, 2023
Merged
Add separate enum for Tag ends #517
Martin1887
merged 16 commits into
pulldown-cmark:master
from
marcusklaas:close-tag-experiments
May 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently on master, all tag details are provided in both tag start and tag end events. For tags that contain allocated details like links, images and tables, this involves a lot of cloning. For most foreseeable use cases (such as HTML rendering), such details are only needed at tag start.
This PR introduces a different enum for tag ends that do not include any allocated tag details. For some tags like tables, this saves not one but two heap allocations per tag. Since the end tag won't include any details, the start tag can 'destructively' take the alignments vector from the allocation structure instead of cloning it.
Of course there are trade-offs. This is a breaking change, and it does add a little complexity (having the same data for tag opens and closes is conceptually satisfying). On the other hand, it does bring us closer to the project's ideals of high performance and avoiding unnecessary copies.
Below are some benchmarks of the current master compared to this branch (so a performance regression below is really a speedup!). The speedup seems to be between 5-10% overall.