Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retrieve functionality #1018

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Add retrieve functionality #1018

merged 1 commit into from
Mar 4, 2024

Conversation

quba42
Copy link
Collaborator

@quba42 quba42 commented Feb 19, 2024

No description provided.

@quba42
Copy link
Collaborator Author

quba42 commented Feb 19, 2024

This currently does not work, because the UniqueTogetherValidator says no before retrieve is ever called.

@quba42 quba42 linked an issue Feb 27, 2024 that may be closed by this pull request
Add retrieve function to all relevant serializers #1010
Closed
@quba42 quba42 force-pushed the retrieve_functionality branch from 850c449 to dd1b239 Compare February 27, 2024 17:18
@quba42 quba42 mentioned this pull request Feb 27, 2024
Closed
@quba42
Copy link
Collaborator Author

quba42 commented Feb 27, 2024

Requieres pulp/pulpcore#5084

@quba42
Copy link
Collaborator Author

quba42 commented Feb 27, 2024

The alternative to the pulpcore change appears to be to switch the serializer from NoArtifactContentSerializer to NoArtifactContentUploadSerializer. But if I do that, then the create API wants to have exactly one of upload or file parameter, and I don't want the API to need those parameters.

This was referenced Feb 28, 2024
Closed
Merged
@quba42 quba42 force-pushed the retrieve_functionality branch from dd1b239 to f123d1d Compare February 28, 2024 14:44
quba42
quba42 commented Feb 28, 2024
View reviewed changes
requirements.txt Outdated Show resolved Hide resolved
@quba42 quba42 force-pushed the retrieve_functionality branch 2 times, most recently from cdfba79 to 359b7b1 Compare February 29, 2024 12:16
@quba42
Copy link
Collaborator Author

quba42 commented Feb 29, 2024

I should add some tests for this!

@quba42 quba42 marked this pull request as ready for review February 29, 2024 12:59
@quba42 quba42 force-pushed the retrieve_functionality branch 2 times, most recently from cbec80f to 16b2cfc Compare March 4, 2024 15:46
hstct
hstct reviewed Mar 4, 2024
View reviewed changes
pulp_deb/tests/functional/conftest.py Outdated Show resolved Hide resolved
pulp_deb/tests/functional/conftest.py Outdated Show resolved Hide resolved
pulp_deb/tests/functional/conftest.py Outdated Show resolved Hide resolved
@quba42 quba42 force-pushed the retrieve_functionality branch from 16b2cfc to d280a5d Compare March 4, 2024 16:48
@quba42 quba42 force-pushed the retrieve_functionality branch 2 times, most recently from 253bd3d to d46fd08 Compare March 4, 2024 17:13
@quba42
Add retrieve functionality
599104f 
closes pulp#1010

In particular we are adding the new behaviour for:

- ReleaseArchitecture
- ReleaseComponent

but deliberately not for PackageReleaseComponent, which should only be
created indirectly using package actions.
@quba42 quba42 force-pushed the retrieve_functionality branch from d46fd08 to 599104f Compare March 4, 2024 17:15
@quba42 quba42 merged commit b912625 into pulp:main Mar 4, 2024
11 checks passed
@quba42 quba42 deleted the retrieve_functionality branch March 4, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hstct hstct hstct approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add retrieve function to all relevant serializers
2 participants
@quba42 @hstct