Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PULP-277] Adapt to 'CONTENT_ORIGIN can be null'. #3865

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[PULP-277] Adapt to 'CONTENT_ORIGIN can be null'. #3865

wants to merge 1 commit into from

Conversation

ggainey
Copy link
Contributor

@ggainey ggainey commented Jan 22, 2025

fixes #3856.

@ggainey ggainey force-pushed the 3856_null_origin branch 5 times, most recently from c966438 to 989f86a Compare January 24, 2025 21:08
@ggainey
Copy link
Contributor Author

ggainey commented Jan 24, 2025

Once pulp/pulpcore#6175 merges I'll remove the temporary distribution_base_url fixture and undraft.

@ggainey ggainey marked this pull request as ready for review January 31, 2025 02:32
@ggainey ggainey requested review from dralley and pedro-psb January 31, 2025 02:32
pedro-psb
pedro-psb reviewed Feb 3, 2025
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
pedro-psb
pedro-psb reviewed Feb 3, 2025
View reviewed changes
Copy link
Member

@pedro-psb pedro-psb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dralley I've added a few comments.

About the pulp_smash test removals, were they redundant? Do we need to recreate them without smash?

@pedro-psb pedro-psb mentioned this pull request Feb 4, 2025
Merged
@ggainey ggainey requested a review from pedro-psb February 9, 2025 19:20
@ggainey
Copy link
Contributor Author

ggainey commented Feb 10, 2025

@dralley I've added a few comments.

About the pulp_smash test removals, were they redundant? Do we need to recreate them without smash?

Those tests were written (I believe) to test a specific problem involving a specific upgrade path a Long Time Ago. They haven't ever actually run, either locally or via CI, since they were added. We have tests for publishing. So I think we're good.

@dralley
Copy link
Contributor

dralley commented Feb 10, 2025

Correct we discussed that in the meeting

Currently this PR is waiting on #3876 FYI

@ggainey ggainey marked this pull request as draft February 12, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dralley dralley dralley approved these changes

@pedro-psb pedro-psb Awaiting requested review from pedro-psb

Assignees
No one assigned
Labels
no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support null CONTENT_ORIGIN
3 participants
@ggainey @dralley @pedro-psb