-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pulp API web interface referencing invalid jquery version #5306
Comments
Does anyone remember why we are shipping this file? It looks like it should be taken directly from drf. |
Looks to be come minor cosmetic customizations, but leveraging the one from drf works 100%. I think that's a better approach to this breaking every few years when they update. Similar to files in /assets/ creating a symlink works:
Not sure where they would go in the pulpcore codebase. I'll go ahead and fix the file for now while some long term thinking takes place. |
We use this template for the /pulp/api/v3/docs/ page. |
As of 3.15.0 version of django-rest-framework the embeded jquery version is now 3.7.1 fixes pulp#5306
As of 3.15.0 version of django-rest-framework the embeded jquery version is now 3.7.1 fixes #5306
Version
pulpcore v3.52.0 and prior likely
Describe the bug
pulpcore/pulpcore/app/templates/rest_framework/api.html
Line 294
<script src="{% static "rest_framework/js/jquery-3.5.1.min.js" %}"></script>
Above line is referencing jquery-3.5.1.min.js and should be referencing jquery-3.7.1.min.js.
pulpcore-manager collectstatic is already puling down the new v3.7.1 file causing multiple features of the web interface to not function.
To Reproduce
Load the API web interface and try clicking on any of the drop downs. GET, FILTER, OPTIONS
Expected behavior
Should load the proper JS files
Additional context
I'll be submitting a PR to fix
The text was updated successfully, but these errors were encountered: