-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare the changelog for the 6.0.0 release #1278
Conversation
This includes a breaking change, so we should release a new major version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we release this, should we address Komal's comment at #1118 (comment)?
Looks like we at least have the refresh option for up and preview in nodejs automation api, but would be great to get this supported for
destroy
as well to have consistency across commands.
Otherwise, it looks like if you're running destroy
with the refresh
option set, we no longer do a refresh at all.
😬 I missed that comment, thanks for catching it! Yes we should! |
Currently refresh support is inconsistent in automation API. Go supports it for up, preview and destroy, NodeJS only supports it for up and preview, and Python doesn't support it at all. Support it for all three in up, preview and destroy. The important bit is supporting it for NodeJS (see pulumi/actions#1278 (review)), but it's best to support it consistently when we can.
pulumi/pulumi#17209 has the changes. We can merge this after merging and releasing that. |
Currently refresh support is inconsistent in automation API. Go supports it for up, preview and destroy, NodeJS only supports it for up and preview, and Python doesn't support it at all. Support it for all three in up, preview and destroy. The important bit is supporting it for NodeJS (see pulumi/actions#1278 (review)), but it's best to support it consistently when we can.
Looks like pulumi/pulumi#17209 has shipped via v3.134.0 |
Indeed, thank you! I submitted a PR to update the pulumi version in this repo here: #1287 Once that's merged I think we can go ahead with the release! |
With #1287 merged this should be unblocked. |
Co-authored-by: Fitz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
CHANGELOG.md
Outdated
--- | ||
|
||
## 6.0.0 (2024-09-09) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs updated date.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks!
This includes a breaking change from #1118, so we should release a new major version.