Remove unsupported LangVersion from dotnet example #2003
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
flostadler
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2003 +/- ##
==========================================
+ Coverage 51.04% 51.07% +0.02%
==========================================
Files 49 49
Lines 7052 7052
==========================================
+ Hits 3600 3602 +2
+ Misses 3200 3198 -2
Partials 252 252 ☔ View full report in Codecov by Sentry. |
flostadler
changed the title
| @@ -1,7 +1,6 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <LangVersion>11</LangVersion> | |||
| <OutputType>Exe</OutputType> | |||
| <TargetFramework>net6.0</TargetFramework> | |||
There was a problem hiding this comment.
You probably want to bump this to net8.0 as well. We saw jobs fail in azure native due to the removal of 6.0 when runner images were updated.
There was a problem hiding this comment.
I tried that first, but turns out there's a bigger issue with most of the native providers: pulumi/ci-mgmt#1307
The installation is rather broken right now, before github upgraded the runners it installed 8.0 and then 3.1.301, right now it's installing 8.0, 6.0 then 3.1.301.
Somehow 6.0 is on the path before 8.0 now and that does not support LangVersion 11.
There was a problem hiding this comment.
We'll first need to fix pulumi/ci-mgmt#1307 before being able to upgrade the target framework
dotnet builds started failing, due to the upgrade of the github runners to ubuntu 24.04.
The
RoleCStest was failing with issues in selectingLanguageVersion11.I've removed that version identifier from the
csprojof the failing test to align with the other CS tests and changed it to not use features from language version 11.Why did this work before?
Previously this worked, because the test implicitly used v8 of the dotnet runtime instead of the requested v6 (configured in ci-mgmt pulumi/ci-mgmt#1307).
The
setup-dotnetaction implicitly installs the latest LTS before installing other versions.We're requesting 6.0.x and on Ubuntu 22.04 this was already pre-installed, so this happened:
Because of that v8 was on the path first and used for tests.
Now on Ubuntu 24.04 v8 is pre-installed, so this happens:
Now we're actually using the requested v6, but the
RoleCstest is not compatible with that.Fixes #2004