Correctly set the alt type for aws_cloudwatch_log_resource_policy

This is a breaking change for Go and Typescript if users were reading the `PolicyDocument` field on LogResourcePolicyArgs or on LogResourcePolicy. This was discovered as part of pulumi/pulumi-terraform-bridge#1758.
pulumi · Mar 27, 2024 · 37abf59 · 37abf59
1 parent c3c2567
commit 37abf59
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 11 deletions.
diff --git a/provider/cmd/pulumi-resource-aws/schema.json b/provider/cmd/pulumi-resource-aws/schema.json
@@ -184553,6 +184553,15 @@
             "inputProperties": {
                 "policyDocument": {
                     "type": "string",
+                    "oneOf": [
+                        {
+                            "type": "string"
+                        },
+                        {
+                            "type": "string",
+                            "$ref": "#/types/aws:iam/documents:PolicyDocument"
+                        }
+                    ],
                     "description": "Details of the resource policy, including the identity of the principal that is enabled to put logs to this account. This is formatted as a JSON string. Maximum length of 5120 characters.\n"
                 },
                 "policyName": {
@@ -184570,6 +184579,15 @@
                 "properties": {
                     "policyDocument": {
                         "type": "string",
+                        "oneOf": [
+                            {
+                                "type": "string"
+                            },
+                            {
+                                "type": "string",
+                                "$ref": "#/types/aws:iam/documents:PolicyDocument"
+                            }
+                        ],
                         "description": "Details of the resource policy, including the identity of the principal that is enabled to put logs to this account. This is formatted as a JSON string. Maximum length of 5120 characters.\n"
                     },
                     "policyName": {

diff --git a/provider/resources.go b/provider/resources.go
@@ -1335,11 +1335,9 @@ func ProviderFromMeta(metaInfo *tfbridge.MetadataInfo) *tfbridge.ProviderInfo {
 				Tok: awsResource(cloudwatchMod, "LogResourcePolicy"),
 				Fields: map[string]*tfbridge.SchemaInfo{
 					"policy_document": {
-						Elem: &tfbridge.SchemaInfo{
-							Type:      "string",
-							AltTypes:  []tokens.Type{awsType(iamMod, "documents", "PolicyDocument")},
-							Transform: tfbridge.TransformJSONDocument,
-						},
+						Type:      "string",
+						AltTypes:  []tokens.Type{awsType(iamMod, "documents", "PolicyDocument")},
+						Transform: tfbridge.TransformJSONDocument,
 					},
 				},
 			},

diff --git a/sdk/go/aws/cloudwatch/logResourcePolicy.go b/sdk/go/aws/cloudwatch/logResourcePolicy.go
diff --git a/sdk/nodejs/cloudwatch/logResourcePolicy.ts b/sdk/nodejs/cloudwatch/logResourcePolicy.ts