Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release verification to aws #1265

Closed
mjeffryes opened this issue Jan 4, 2025 · 1 comment · Fixed by pulumi/pulumi-aws#5053
Closed

Add release verification to aws #1265

mjeffryes opened this issue Jan 4, 2025 · 1 comment · Fixed by pulumi/pulumi-aws#5053
Assignees
@corymhall
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone
0.115

Comments

@mjeffryes
Copy link
Member

We should hook up some examples the to release verification workflow to smoke test releases. Additional context and examples in parent.
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Jan 4, 2025
@iwahbe iwahbe added kind/enhancement Improvements or new features and removed needs-triage Needs attention from the triage team labels Jan 7, 2025
@corymhall
Copy link
Contributor

closed by pulumi/pulumi-aws#5034

@corymhall corymhall added the resolution/fixed This issue was fixed label Jan 7, 2025
@corymhall corymhall reopened this Jan 8, 2025
corymhall added a commit that referenced this issue Jan 8, 2025
@corymhall
Run preTest actions during release verification workflow
01bb5af 
The ci-mgmt config has a configuration property for `preTest` jobs.
These are run during the `test` workflow before the tests themselves are
run. Since the verify release workflow runs the same tests we should
also run these `preTest` steps. For example, in `pulumi-aws` we have
`preTest` jobs to get AWS credentials which are required to run the
tests in the verify release workflow.

re pulumi/pulumi-aws#5049, re #1265
@corymhall corymhall mentioned this issue Jan 8, 2025
Merged
corymhall added a commit to pulumi/verify-provider-release that referenced this issue Jan 8, 2025
@corymhall
fix: pip commands failing on windows
153a79c 
Running into this while trying to roll out release verification to
pulumi-aws. I was getting this error message on python tests.

```
ERROR: To modify pip, please run the following command:
C:\Users\runneradmin\AppData\Local\Temp\pulumi-verify-release-oTGHJ3\release-verification-py\venv\Scripts\python3.exe -m pip install pulumi-aws==6.66.2
```

Changing the pip command to be `python3.exe -m pip` fixes the issue. See
[this
run](https://github.com/pulumi/pulumi-aws/actions/runs/12678045378).

re pulumi/ci-mgmt#1265
@corymhall corymhall mentioned this issue Jan 8, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 8, 2025
@corymhall
Run preTest actions during release verification workflow (#1274)
8531096 
The ci-mgmt config has a configuration property for `preTest` jobs.
These are run during the `test` workflow before the tests themselves are
run. Since the verify release workflow runs the same tests we should
also run these `preTest` steps. For example, in `pulumi-aws` we have
`preTest` jobs to get AWS credentials which are required to run the
tests in the verify release workflow.

re pulumi/pulumi-aws#5049, re #1265
corymhall added a commit to pulumi/verify-provider-release that referenced this issue Jan 9, 2025
@corymhall
fix: pip commands failing on windows (#90)
d1001d5 
Running into this while trying to roll out release verification to
pulumi-aws. I was getting this error message on python tests.

```
ERROR: To modify pip, please run the following command:
C:\Users\runneradmin\AppData\Local\Temp\pulumi-verify-release-oTGHJ3\release-verification-py\venv\Scripts\python3.exe -m pip install pulumi-aws==6.66.2
```

Changing the pip command to be `python3.exe -m pip` fixes the issue. See
[this
run](https://github.com/pulumi/pulumi-aws/actions/runs/12678045378).

re pulumi/ci-mgmt#1265
@corymhall corymhall mentioned this issue Jan 9, 2025
Merged
@mjeffryes mjeffryes added this to the 0.115 milestone Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corymhall corymhall

Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Milestone
0.115
Development

Successfully merging a pull request may close this issue.

chore: enable release verification take 2 pulumi/pulumi-aws
4 participants
@mjeffryes @iwahbe @pulumi-bot @corymhall