Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable release verification take 2 #5053

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

corymhall
Copy link
Contributor

@corymhall corymhall commented Jan 8, 2025

This enables release verification for AWS.

Tested by manually executing the Verify-Release workflow using this branch. Run can be seen here https://github.com/pulumi/pulumi-aws/actions/runs/12691069824

closes pulumi/ci-mgmt#1265

@corymhall corymhall self-assigned this Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.42%. Comparing base (ff2e31e) to head (0676722).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5053   +/-   ##
=======================================
  Coverage   24.42%   24.42%           
=======================================
  Files         360      360           
  Lines      143403   143403           
=======================================
  Hits        35023    35023           
  Misses     108281   108281           
  Partials       99       99           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

runtime: python
runtime:
name: python
options:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the existing nodejs example tests required a config value to be set. Copied over the bucket example and removed that config.

@corymhall corymhall marked this pull request as ready for review January 9, 2025 14:03
@corymhall corymhall requested review from t0yv0 and flostadler January 9, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add release verification to aws
1 participant