-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry for all tag fetching #3765
Conversation
Does the PR have any schema changes?Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Is README.md missing any configuration options?
Please add a description for each of these options to |
examples/examples_go_test.go
Outdated
retries := 5 | ||
client := s3sdk.New(sess, &aws.Config{MaxRetries: &retries}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice to leave a comment here noting the reason we need to retry
examples/examples_go_test.go
Outdated
@@ -242,7 +244,8 @@ func fetchAppConfigTags(t *testing.T, arn string) map[string]string { | |||
sess := session.Must(session.NewSessionWithOptions(session.Options{ | |||
SharedConfigState: session.SharedConfigEnable, | |||
})) | |||
client := appconfigsdk.New(sess) | |||
retries := 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
37c1377
to
71cbd64
Compare
Caught a few more different reasons for this flaky test; this is really difficult to reproduce but I'm guessing it may be about the eventual consistency of having actual tags in AWS. Add some outer retries around fetching actual tags as well. Let's see if this stops flaking. Going to close it optimistically. |
TestRandomTagsComabinationsGo periodically flakes up on failing to retrieve tags from AWS. This small change should add a retry to hopefully make it more robust.
Fixes #3403