Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Deprecation: inline rules for SecurityGroup and NetworkAcl resources" #3785

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

EronWright
Copy link
Contributor

This reverts commit 8fc4907 from #3729

The warning message is considered too noisy for this sort of issue.

@EronWright EronWright requested review from a team and lukehoban April 8, 2024 23:13
@EronWright EronWright enabled auto-merge April 8, 2024 23:25
Copy link

github-actions bot commented Apr 8, 2024

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link

github-actions bot commented Apr 8, 2024

Is README.md missing any configuration options?

assumeRoleWithWebIdentity not found in Configuration section
customCaBundle not found in Configuration section
defaultTags not found in Configuration section
ec2MetadataServiceEndpoint not found in Configuration section
ec2MetadataServiceEndpointMode not found in Configuration section
httpProxy not found in Configuration section
httpsProxy not found in Configuration section
ignoreTags not found in Configuration section
noProxy not found in Configuration section
retryMode not found in Configuration section
s3UsEast1RegionalEndpoint not found in Configuration section
sharedConfigFiles not found in Configuration section
skipRequestingAccountId not found in Configuration section
stsRegion not found in Configuration section
tokenBucketRateLimiterCapacity not found in Configuration section
useDualstackEndpoint not found in Configuration section

Please add a description for each of these options to README.md. Details about them can be found in either the upstream docs or schema.json.

@t0yv0
Copy link
Member

t0yv0 commented Apr 9, 2024

We'll release it when #3789 unblock the python tests and this PR rebases on top.

@t0yv0 t0yv0 force-pushed the eronwright/issue-1031-revert branch from ec255f8 to 4f603f8 Compare April 9, 2024 19:19
@t0yv0
Copy link
Member

t0yv0 commented Apr 9, 2024

Rebased on master.

@EronWright EronWright merged commit 1eaf9df into master Apr 9, 2024
23 checks passed
@EronWright EronWright deleted the eronwright/issue-1031-revert branch April 9, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants