Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream v5.44.0 #3792

Merged
merged 8 commits into from
Apr 11, 2024
Merged

Upstream v5.44.0 #3792

merged 8 commits into from
Apr 11, 2024

Conversation

corymhall
Copy link
Contributor

This change updates pulumi-aws to the v5.44.0 version of the upstream provider.

See upstream release notes for the detailed list of changes: hashicorp/[email protected] (release)

@corymhall corymhall force-pushed the corymhall/upgrade-5.44 branch from 8d435f3 to e1df055 Compare April 9, 2024 19:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 10, 2024 •
edited
Loading

Does the PR have any schema changes?

Does the PR have any schema changes?

Found 2 breaking changes:

Types

  • 🟢 "aws:appstream/FleetComputeCapacity:FleetComputeCapacity": required: "desiredInstances" property is no longer Required
  • 🟢 "aws:glue/getDataCatalogEncryptionSettingsDataCatalogEncryptionSettingEncryptionAtRest:getDataCatalogEncryptionSettingsDataCatalogEncryptionSettingEncryptionAtRest": required: "catalogEncryptionServiceRole" property has changed to Required

New resources:

  • devopsguru/serviceIntegration.ServiceIntegration

New functions:

  • devopsguru/getNotificationChannel.getNotificationChannel
  • devopsguru/getResourceCollection.getResourceCollection
  • ecr/getLifecyclePolicyDocument.getLifecyclePolicyDocument

Maintainer note: consult the runbook for dealing with any breaking changes.

@github-actions GitHub Actions
Copy link

Is README.md missing any configuration options?

assumeRoleWithWebIdentity not found in Configuration section
customCaBundle not found in Configuration section
defaultTags not found in Configuration section
ec2MetadataServiceEndpoint not found in Configuration section
ec2MetadataServiceEndpointMode not found in Configuration section
httpProxy not found in Configuration section
httpsProxy not found in Configuration section
ignoreTags not found in Configuration section
noProxy not found in Configuration section
retryMode not found in Configuration section
s3UsEast1RegionalEndpoint not found in Configuration section
sharedConfigFiles not found in Configuration section
skipRequestingAccountId not found in Configuration section
stsRegion not found in Configuration section
tokenBucketRateLimiterCapacity not found in Configuration section
useDualstackEndpoint not found in Configuration section

Please add a description for each of these options to README.md. Details about them can be found in either the upstream docs or schema.json.

t0yv0
t0yv0 reviewed Apr 10, 2024
View reviewed changes
patches/0002-Conns-user-agent.patch
// ServicePackage is the minimal interface exported from each AWS service package.
@@ -80,10 +79,10 @@ func NewSessionForRegion(cfg *aws_sdkv1.Config, region, terraformVersion string)

func StdUserAgentProducts(terraformVersion string) *awsbase.APNInfo {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed anymore? Looks like this was fixing up User Agent somewhere in one of the clients?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh good catch! It looks like this configuration was moved somewhere else. I'll create another patch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I added another patch https://github.com/pulumi/pulumi-aws/pull/3792/files#diff-fec171c8e8ff659477dbbd56f2c37c3c617a42bcd723bdc592099abfa111b2c5

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it looks like an untested patch .. maybe one day we'll backfill the test for it so it'd remind us.

t0yv0
t0yv0 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me except for that one patch question! The rest of the patches look reasonable. Thank you!

@t0yv0
Copy link
Member

t0yv0 commented Apr 11, 2024

LGTM after tests pass!

@corymhall corymhall merged commit c1939a0 into master Apr 11, 2024
23 checks passed
@corymhall corymhall deleted the corymhall/upgrade-5.44 branch April 11, 2024 14:20
@corymhall
Copy link
Contributor Author

/release minor

@github-actions github-actions bot added the needs-release/minor When a PR with this label merges, it initiates a release of vX.Y+1.0 label Apr 11, 2024
@corymhall corymhall mentioned this pull request Apr 11, 2024
Closed
@github-actions github-actions bot removed the needs-release/minor When a PR with this label merges, it initiates a release of vX.Y+1.0 label Apr 11, 2024
@jamie1911 jamie1911 mentioned this pull request Apr 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t0yv0 t0yv0 t0yv0 approved these changes

Assignees

@corymhall corymhall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corymhall @t0yv0