fix: sns topic creation should not be idempotent

[corymhall]

This is a re-roll of #3235.

See this comment for why we are re-rolling this.

Previously the creation of an SNS topic was idempotent, so you could create multiple pulumi resources corresponding to the same SNS topic, causing confusing behaviour when one was deleted/replaced.

With this PR, trying to create a topic which exists will error.

Note that this is kind of a breaking change - pulumi programs where the same SNS topic was created through multiple pulumi resources would run fine before but will now error.

Note also the mutex around the listing and creating of SNS topics - this is needed to prevent race conditions within the same program. Race conditions with other programs are still possible and that is unavoidable because of the AWS API.

fixes #3288, fixes #2009.

Co-authored-by: VenelinMartinov [email protected]

[corymhall]

@t0yv0 I recreated this because I totally botched trying to rebase from master after the upgrade.

[github-actions]

Does the PR have any schema changes?

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

[github-actions]

Is README.md missing any configuration options?

assumeRoleWithWebIdentity not found in Configuration section
customCaBundle not found in Configuration section
defaultTags not found in Configuration section
ec2MetadataServiceEndpoint not found in Configuration section
ec2MetadataServiceEndpointMode not found in Configuration section
httpProxy not found in Configuration section
httpsProxy not found in Configuration section
ignoreTags not found in Configuration section
noProxy not found in Configuration section
retryMode not found in Configuration section
s3UsEast1RegionalEndpoint not found in Configuration section
sharedConfigFiles not found in Configuration section
skipRequestingAccountId not found in Configuration section
stsRegion not found in Configuration section
tokenBucketRateLimiterCapacity not found in Configuration section
useDualstackEndpoint not found in Configuration section

Please add a description for each of these options to README.md. Details about them can be found in either the upstream docs or schema.json.

[t0yv0]

This looks right. Thank you! Much appreciated taking some extra care to avoid a global chokepoint.

[t0yv0]

🚢

[t0yv0]

When merging please update the merge commit with the original description - we build release notes from the commit messages and it's great to have a good summary there of what the users are getting. Much appreciated.