Upgrade pulumi-terraform-bridge to v3.97.0 #4898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
flostadler
requested review from
t0yv0,
iwahbe,
corymhall,
a team and
VenelinMartinov
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4898 +/- ##
==============================
==============================
☔ View full report in Codecov by Sentry. |
flostadler
added a commit
that referenced
this pull request
Dec 10, 2024
This reverts commit 316ee6a.
flostadler
added a commit
that referenced
this pull request
Dec 10, 2024
This reverts commit 316ee6a. Rolling back 3.97.0 due to pulumi/pulumi-terraform-bridge#2706
corymhall
added a commit
that referenced
this pull request
Dec 11, 2024
|
This PR has been shipped in release v6.65.0. |
This was referenced Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated via
$ upgrade-provider pulumi/pulumi-aws --kind=bridge.Manual Changes:
Please pay special attention to
provider/pkg/batch/compute_environment.goandprovider/pkg/batch/compute_environment_test.go. The test was previously using theloggingpackage from theunstablemodule that shouldn't have been used outside of the bridge. This package was recently moved to be internal (pulumi/pulumi-terraform-bridge#2687). To get around that we now pass in the logger as a dependency and fake it in tests.Fixes #4759
Fixes #4894