fix: Restore minimal schema #5020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since v6.62.1 minimal schema was not working. This is now fixed. A change in standard CI scripts aimed at speeding up makefiles broke the assumptions of pulumi-aws specific Makefile extensions in .mk/minimal_schema.mk - that is CI would now run `make --touch provider schema` which would create an empty provider/cmd/pulumi-resource-aws/schema-minimal-embed.json file instead of recalculating it. The change in question is: pulumi/ci-mgmt#1157 The fix makes `minimal_schema` a PHONY target that may be a bit less efficient for rebuilding but is no longer affected by `make --touch`. A regression test is added to catch this problem should it reoccur. Fixes #5016
corymhall
approved these changes
Dec 30, 2024
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5020 +/- ##
=======================================
Coverage 24.42% 24.42%
=======================================
Files 360 360
Lines 143403 143403
=======================================
Hits 35023 35023
Misses 108281 108281
Partials 99 99 ☔ View full report in Codecov by Sentry. |
|
/release patch |
github-actions
bot
added
the
needs-release/patch
|
This PR has been shipped in release v6.66.2. |
github-actions
bot
removed
the
needs-release/patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since v6.62.1 minimal schema was not working. This is now fixed.
A change in standard CI scripts aimed at speeding up makefiles broke the assumptions of pulumi-aws specific Makefile extensions in .mk/minimal_schema.mk - that is CI would now run
make --touch provider schemawhich would create an empty provider/cmd/pulumi-resource-aws/schema-minimal-embed.json file instead of recalculating it.The change in question is: pulumi/ci-mgmt#1157
The fix makes
minimal_schemaa PHONY target that may be a bit less efficient for rebuilding but is no longer affected bymake --touch.A regression test is added to catch this problem should it reoccur.
Fixes #5016