Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt IPAM functionality #1014

Merged
merged 7 commits into from
May 1, 2023
Merged

Adopt IPAM functionality #1014

merged 7 commits into from
May 1, 2023

Conversation

BongoEADGC6
Copy link
Contributor

In reference to Issue: #872

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@BongoEADGC6 BongoEADGC6 mentioned this pull request Mar 27, 2023
Closed
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@BongoEADGC6
Copy link
Contributor Author

/run-acceptance-tests

1 similar comment
@mikhailshilkov
Copy link
Member

/run-acceptance-tests

@github-actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-awsx/actions/runs/4722984470

@mikhailshilkov mikhailshilkov requested a review from a team April 18, 2023 08:48
rquitales
rquitales requested changes Apr 19, 2023
View reviewed changes
Copy link
Member

@rquitales rquitales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BongoEADGC6 Thanks for submitting this PR. Overall, this looks good to me, but we have a test failing as the code you submitted is not linted. Could you run make lint lint_classic and commit the changes?
Thanks!

@BongoEADGC6
Copy link
Contributor Author

@rquitales Done and ready for approval

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@rquitales
Copy link
Member

/run-acceptance-tests

@github-actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-awsx/actions/runs/4748662010

@rquitales
Copy link
Member

/run-acceptance-tests

@github-actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-awsx/actions/runs/4758018904

rquitales
rquitales approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@rquitales rquitales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this fix, and sorry for getting this merged in late.

@rquitales rquitales merged commit 4a0b97b into pulumi:master May 1, 2023
@thomas11 thomas11 mentioned this pull request Jun 30, 2023
Closed
thomas11 added a commit that referenced this pull request Jul 6, 2023
@thomas11
Revert "Adopt IPAM functionality (#1014)"
42eacd8 
This reverts commit 4a0b97b.
@thomas11 thomas11 mentioned this pull request Jul 7, 2023
Merged
thomas11 added a commit that referenced this pull request Jul 7, 2023
@thomas11
Revert "Adopt IPAM functionality (#1014)" (#1038)
62df315 
This reverts commit 4a0b97b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rquitales rquitales rquitales approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BongoEADGC6 @mikhailshilkov @rquitales @CyberArkCH3