Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip flattening if properties would clash #3195

Closed
danielrbradley opened this issue Apr 2, 2024 · 2 comments · Fixed by #3839
Closed

Skip flattening if properties would clash #3195

danielrbradley opened this issue Apr 2, 2024 · 2 comments · Fixed by #3839
Assignees
@thomas11
Labels
3.0 impact/accessibility Something that is difficult or impossible for some people to use kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone
0.115

Comments

@danielrbradley
Copy link
Member

Draft PR: #3016

Skip the flattening of nested properties indicated by x-ms-client-flatten if it would lead to overwriting a property, creating incorrect schema and SDKs. This case happens when inner and outer property have the same name, for a report on all occurrences see #3013.

This change is breaking and could therefore only be applied to v3 of the provider. The purpose of the PR is mainly to illustrate the SDK changes that would result.

Note: remember to remove exception added in #3007.
@danielrbradley danielrbradley added kind/enhancement Improvements or new features impact/accessibility Something that is difficult or impossible for some people to use 3.0 labels Apr 2, 2024
@cleverguy25
Copy link

Added to epic https://github.com/pulumi/home/issues/3552

@mjeffryes mjeffryes added this to the 0.114 milestone Dec 3, 2024
@thomas11 thomas11 mentioned this issue Dec 17, 2024
Closed
@thomas11 thomas11 mentioned this issue Jan 8, 2025
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Jan 8, 2025
@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #3839 and shipped in release v2.82.0.

@mjeffryes mjeffryes modified the milestones: 0.114, 0.115 Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomas11 thomas11

Labels
3.0 impact/accessibility Something that is difficult or impossible for some people to use kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
[Project] Azure Native V3
Status: Done
Milestone
0.115
5 participants
@thomas11 @danielrbradley @mjeffryes @cleverguy25 @pulumi-bot