[v3] Skip flattening if properties would clash - PR #2 #3839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3839 +/- ##
==========================================
- Coverage 57.00% 56.96% -0.04%
==========================================
Files 78 78
Lines 12035 12062 +27
==========================================
+ Hits 6860 6871 +11
- Misses 4675 4691 +16
Partials 500 500 ☔ View full report in Codecov by Sentry. |
danielrbradley
approved these changes
Jan 8, 2025
|
@danielrbradley I forgot in the PR description: I rebuilt everything pretending to be on v3 (editing the boolean condition). Branch tkappler/v3-skip-flattening-2-v3gen contains the result, just for inspection, not to be merged. |
|
Cool that looks spot on. (Direct link to commit: 2f823f5) |
|
This PR has been shipped in release v2.82.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip the flattening of nested properties indicated by x-ms-client-flatten if it would lead to overwriting a property, creating incorrect schema and SDKs. This case happens when inner and outer property have the same name. For a report on all occurrences see #3013.
This change is breaking and could therefore only be applied to v3 of the provider.
The PR is written to be reviewed commit by commit. It supersedes the previous #3801. I recommend hiding whitespace when reviewing since the level of indentation of otherwise unaffected code changed.
Resolves #3195