Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin p-java to v0.10.0 due to pulumi-java#1363 #3302

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

thomas11
Copy link
Contributor

Due to pulumi/pulumi-java#1363, malformed Javadoc prevents us from publishing the provider SDK for Java. Pin to the working previous version of pulumi-java.

Tested locally:

$ make generate_java

$ cd sdk/java && gradle javadoc

If .pulumi-java-gen.version is v0.10.0, gradle succeeds; if it's v0.11.0, it fails.

@thomas11 thomas11 requested review from danielrbradley and a team May 22, 2024 05:58
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.35%. Comparing base (44445c3) to head (cf8108e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3302   +/-   ##
=======================================
  Coverage   55.35%   55.35%           
=======================================
  Files          66       66           
  Lines        9934     9934           
=======================================
  Hits         5499     5499           
  Misses       4001     4001           
  Partials      434      434           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas11 thomas11 merged commit d831353 into master May 22, 2024
24 checks passed
@thomas11 thomas11 deleted the tkappler/pin-java-010 branch May 22, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants