-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve auth CLI missing error #3349
Conversation
Add context for why the CLI is expected and what operation is being attempted. Fixes #3347
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3349 +/- ##
==========================================
- Coverage 56.82% 56.82% -0.01%
==========================================
Files 66 66
Lines 8082 8083 +1
==========================================
Hits 4593 4593
- Misses 3054 3055 +1
Partials 435 435 ☔ View full report in Codecov by Sentry. |
The message is missing a period, semicolon or the like after |
Oh that was just me mocking up the diagnostics. It actually has a colon between. Updated the example. |
@@ -123,11 +123,12 @@ func (k *azureNativeProvider) getAuthConfig() (*authConfig, error) { | |||
|
|||
needCli := needAzCli(builder) | |||
if needCli { | |||
requireCliHint := "MSI, OIDC, client secret and client certificate authentication are not configured so we require the AZ CLI for authentication" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AZ CLI
It's called Azure CLI in all official product docs. If you mean the command, then it's probably lowercase az
.
Add context for why the CLI is expected and what operation is being attempted.
Fixes #3347
This will now print a message like: