Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly gen #3527

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Fix nightly gen #3527

merged 3 commits into from
Aug 20, 2024

Conversation

danielrbradley
Copy link
Member

Fixes #3523

Exclude renamed IoT Operations resources

These only vary by case and also conflict with the existing versions.

Improve failed gen output

  • Still output version info and reports even when we've not finished the generation to highlight any significant changes - such as new resources being added to the default version.
  • Improve error message so it shows the full path to the failed type.

Before:
panic: failed to generate 'azure-native:iotoperations:Dataflow': response type: incompatible type "azure-native:iotoperations:DataFlowOperationResponse" for resource "Dataflow" ("azure-native:iotoperations:Dataflow"): refs do not match: #/types/azure-native:iotoperations:DataflowDestinationOperationSettingsResponse vs #/types/azure-native:iotoperations:DataFlowDestinationOperationResponse

After:
panic: failed to generate 'azure-native:iotoperations:Dataflow': response type: failed to generate property "properties": failed to generate type spec for property "properties": failed to generate property "operations": failed to generate type spec for property "operations": failed to generate type spec for array element: failed to generate type spec for property "operations": incompatible type "azure-native:iotoperations:DataFlowOperationResponse" for resource "Dataflow" ("azure-native:iotoperations:Dataflow"): refs do not match: #/types/azure-native:iotoperations:DataflowBuiltInTransformationSettingsResponse vs #/types/azure-native:iotoperations:DataFlowBuiltInTransformationResponse

@danielrbradley danielrbradley self-assigned this Aug 20, 2024
- Still output version info and reports even when we've not finished the generation to highlight any significant changes - such as new resources being added to the default version.
- Improve error message so it shows the full path to the failed type.

Before:
    panic: failed to generate 'azure-native:iotoperations:Dataflow': response type: incompatible type "azure-native:iotoperations:DataFlowOperationResponse" for resource "Dataflow" ("azure-native:iotoperations:Dataflow"): refs do not match: #/types/azure-native:iotoperations:DataflowDestinationOperationSettingsResponse vs #/types/azure-native:iotoperations:DataFlowDestinationOperationResponse

After:
    panic: failed to generate 'azure-native:iotoperations:Dataflow': response type: failed to generate property "properties": failed to generate type spec for property "properties": failed to generate property "operations": failed to generate type spec for property "operations": failed to generate type spec for array element: failed to generate type spec for property "operations": incompatible type "azure-native:iotoperations:DataFlowOperationResponse" for resource "Dataflow" ("azure-native:iotoperations:Dataflow"): refs do not match: #/types/azure-native:iotoperations:DataflowBuiltInTransformationSettingsResponse vs #/types/azure-native:iotoperations:DataFlowBuiltInTransformationResponse
These only vary by case and also conflict with the existing versions.
Copy link
Contributor

@thomas11 thomas11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This contains the latest spec as well, I assume?

@danielrbradley
Copy link
Member Author

This contains the latest spec as well, I assume?

Yes - latest as of yesterday.

Copy link

Does the PR have any schema changes?

Found 9 breaking changes:

Resources

  • "azure-native:documentdb:FirewallRule":
    • inputs:
      • 🟡 "endIpAddress" missing
      • 🟡 "startIpAddress" missing
    • properties:
      • 🟡 "endIpAddress" missing output "endIpAddress"
      • 🟡 "provisioningState" missing output "provisioningState"
      • 🟡 "startIpAddress" missing output "startIpAddress"

Types

  • 🟡 "azure-native:billing:InvoiceSectionProperties": properties: "targetCloud" type changed from "" to "string"
  • 🔴 "azure-native:billing:TargetCloud" missing
  • 🟢 "azure-native:datafactory:SharePointOnlineListLinkedService": required: "servicePrincipalKey" property is no longer Required
  • 🟢 "azure-native:datafactory:SharePointOnlineListLinkedServiceResponse": required: "servicePrincipalKey" property is no longer Required

New resources:

  • network.IpamPool
  • network.ReachabilityAnalysisIntent
  • network.ReachabilityAnalysisRun
  • network.StaticCidr
  • network.VerifierWorkspace

New functions:

  • network.getIpamPool
  • network.getIpamPoolUsage
  • network.getReachabilityAnalysisIntent
  • network.getReachabilityAnalysisRun
  • network.getStaticCidr
  • network.getVerifierWorkspace
  • network.listIpamPoolAssociatedResources

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 3.22581% with 30 lines in your changes missing coverage. Please review.

Project coverage is 57.69%. Comparing base (a1078c4) to head (73af7b3).
Report is 4 commits behind head on master.

Files Patch % Lines
provider/pkg/versioning/build_schema.go 0.00% 15 Missing ⚠️
provider/pkg/gen/types.go 0.00% 7 Missing ⚠️
provider/pkg/gen/properties.go 14.28% 6 Missing ⚠️
provider/cmd/pulumi-gen-azure-native/main.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3527      +/-   ##
==========================================
+ Coverage   57.63%   57.69%   +0.06%     
==========================================
  Files          66       66              
  Lines        8292     8292              
==========================================
+ Hits         4779     4784       +5     
+ Misses       3067     3063       -4     
+ Partials      446      445       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielrbradley danielrbradley merged commit cbdf0b7 into master Aug 20, 2024
23 checks passed
@danielrbradley danielrbradley deleted the fix-nightly-gen branch August 20, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow failure: nightly-sdk-generation
2 participants