-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nightly gen #3527
Fix nightly gen #3527
Conversation
- Still output version info and reports even when we've not finished the generation to highlight any significant changes - such as new resources being added to the default version. - Improve error message so it shows the full path to the failed type. Before: panic: failed to generate 'azure-native:iotoperations:Dataflow': response type: incompatible type "azure-native:iotoperations:DataFlowOperationResponse" for resource "Dataflow" ("azure-native:iotoperations:Dataflow"): refs do not match: #/types/azure-native:iotoperations:DataflowDestinationOperationSettingsResponse vs #/types/azure-native:iotoperations:DataFlowDestinationOperationResponse After: panic: failed to generate 'azure-native:iotoperations:Dataflow': response type: failed to generate property "properties": failed to generate type spec for property "properties": failed to generate property "operations": failed to generate type spec for property "operations": failed to generate type spec for array element: failed to generate type spec for property "operations": incompatible type "azure-native:iotoperations:DataFlowOperationResponse" for resource "Dataflow" ("azure-native:iotoperations:Dataflow"): refs do not match: #/types/azure-native:iotoperations:DataflowBuiltInTransformationSettingsResponse vs #/types/azure-native:iotoperations:DataFlowBuiltInTransformationResponse
These only vary by case and also conflict with the existing versions.
6b345c2
to
73af7b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This contains the latest spec as well, I assume?
Yes - latest as of yesterday. |
Does the PR have any schema changes?Found 9 breaking changes: Resources
Types
New resources:
New functions:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3527 +/- ##
==========================================
+ Coverage 57.63% 57.69% +0.06%
==========================================
Files 66 66
Lines 8292 8292
==========================================
+ Hits 4779 4784 +5
+ Misses 3067 3063 -4
+ Partials 446 445 -1 ☔ View full report in Codecov by Sentry. |
Fixes #3523
Exclude renamed IoT Operations resources
These only vary by case and also conflict with the existing versions.
Improve failed gen output
Before:
panic: failed to generate 'azure-native:iotoperations:Dataflow': response type: incompatible type "azure-native:iotoperations:DataFlowOperationResponse" for resource "Dataflow" ("azure-native:iotoperations:Dataflow"): refs do not match: #/types/azure-native:iotoperations:DataflowDestinationOperationSettingsResponse vs #/types/azure-native:iotoperations:DataFlowDestinationOperationResponse
After:
panic: failed to generate 'azure-native:iotoperations:Dataflow': response type: failed to generate property "properties": failed to generate type spec for property "properties": failed to generate property "operations": failed to generate type spec for property "operations": failed to generate type spec for array element: failed to generate type spec for property "operations": incompatible type "azure-native:iotoperations:DataFlowOperationResponse" for resource "Dataflow" ("azure-native:iotoperations:Dataflow"): refs do not match: #/types/azure-native:iotoperations:DataflowBuiltInTransformationSettingsResponse vs #/types/azure-native:iotoperations:DataFlowBuiltInTransformationResponse