Correctly handle missing WebApps and document the custom resource interface better #3533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
danielrbradley
approved these changes
Aug 21, 2024
| @@ -52,7 +52,7 @@ func makeWebAppResource(resourceType, path string, crudClientFactory crud.Resour | |||
| // the WebApp does not return the SiteConfig. We need to make a separate GET request to | |||
| // /config/web and merge the results. #1468 | |||
| Read: func(ctx context.Context, id string, inputs resource.PropertyMap) (map[string]any, bool, error) { | |||
| // We can reasanably assume that WebApp and WebAppSlot share their API version since they are almost identical. | |||
| // We assume that WebApp and WebAppSlot share their API version since they are almost identical. | |||
| apiVersion, ok := versionLookup.GetDefaultApiVersionForResource("Web", "WebApp") | |||
There was a problem hiding this comment.
A slight aside from your changes ... I think just fetching the default API version here might be incorrect. I think this code is called for explict versions of the WebApp resource too - at which point we should be fetching the version associated to the resource token that the user is using.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3533 +/- ##
==========================================
- Coverage 57.72% 57.68% -0.05%
==========================================
Files 66 66
Lines 8299 8305 +6
==========================================
Hits 4791 4791
- Misses 3063 3069 +6
Partials 445 445 ☔ View full report in Codecov by Sentry. |
thomas11
force-pushed
the
tkappler/refresh-deleted-webapp
branch
from
2dd7a87 to
01f0623
Compare
|
This PR has been shipped in release v2.57.1. |
thomas11
added a commit
that referenced
this pull request
Aug 22, 2024
…erface better (#3533) Fixes #3526 The WebApp custom resource currently returns (notFound, error) when the requested app doesn't exist. Although undocumented, the downstream assumes that custom resources return (notFound, nil) in that case. I.e., it's the responsibility of the custom resource to distinguish between "not found" and other kinds of errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3526
The WebApp custom resource currently returns (notFound, error) when the requested app doesn't exist. Although undocumented, the downstream assumes that custom resources return (notFound, nil) in that case. I.e., it's the responsibility of the custom resource to distinguish between "not found" and other kinds of errors.