Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unused codegen code #3538

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Clean up unused codegen code #3538

merged 2 commits into from
Aug 23, 2024

Conversation

thomas11
Copy link
Contributor

@thomas11 thomas11 commented Aug 23, 2024

  • Remove unused code from gen/main
  • We only need GeneratePackage for Go

This also helps making our code more resilient against upstream p/p changes.

@thomas11 thomas11 requested review from danielrbradley and a team August 23, 2024 05:27
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 57.79%. Comparing base (d60a23b) to head (0c2a30c).
Report is 2 commits behind head on master.

Files Patch % Lines
provider/cmd/pulumi-gen-azure-native/main.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3538      +/-   ##
==========================================
+ Coverage   57.68%   57.79%   +0.10%     
==========================================
  Files          66       66              
  Lines        8305     8281      -24     
==========================================
- Hits         4791     4786       -5     
+ Misses       3069     3049      -20     
- Partials      445      446       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas11 thomas11 merged commit bed4c1e into master Aug 23, 2024
24 checks passed
@thomas11 thomas11 deleted the tkappler/cleanup-gen-main branch August 23, 2024 08:19
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v2.58.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants