Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly upgrade #3544

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Fix nightly upgrade #3544

merged 2 commits into from
Aug 28, 2024

Conversation

danielrbradley
Copy link
Member

@danielrbradley danielrbradley commented Aug 28, 2024

Fixes #3543

Exclude new workloads version. The new version appears to have renamed some resources which then get included alongside the existing resources but cause name conflicts in some SDKs.

Source of breaking changes in the security module:

The new version appears to have renamed some resources which then get included alongside the existing resources but cause name conflicts in some SDKs.
@danielrbradley danielrbradley self-assigned this Aug 28, 2024
Copy link

Does the PR have any schema changes?

Found 13 breaking changes:

Resources

  • 🔴 "azure-native:security:AdaptiveApplicationControl" missing

Functions

  • 🔴 "azure-native:security:getAdaptiveApplicationControl" missing

Types

  • 🔴 "azure-native:security:AdaptiveApplicationControlIssueSummaryResponse" missing
  • 🔴 "azure-native:security:PathRecommendation" missing
  • 🔴 "azure-native:security:PathRecommendationResponse" missing
  • 🔴 "azure-native:security:ProtectionMode" missing
  • 🔴 "azure-native:security:ProtectionModeResponse" missing
  • 🔴 "azure-native:security:PublisherInfo" missing
  • 🔴 "azure-native:security:PublisherInfoResponse" missing
  • 🔴 "azure-native:security:UserRecommendation" missing
  • 🔴 "azure-native:security:UserRecommendationResponse" missing
  • 🔴 "azure-native:security:VmRecommendation" missing
  • 🔴 "azure-native:security:VmRecommendationResponse" missing

New resources:

  • networkcloud.KubernetesClusterFeature

New functions:

  • networkcloud.getKubernetesClusterFeature

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.79%. Comparing base (92211f1) to head (dddc752).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3544   +/-   ##
=======================================
  Coverage   57.79%   57.79%           
=======================================
  Files          66       66           
  Lines        8281     8281           
=======================================
  Hits         4786     4786           
  Misses       3049     3049           
  Partials      446      446           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielrbradley danielrbradley enabled auto-merge (squash) August 28, 2024 11:27
@danielrbradley danielrbradley enabled auto-merge (squash) August 28, 2024 11:30
@danielrbradley danielrbradley merged commit 6b9f17f into master Aug 28, 2024
24 checks passed
@danielrbradley danielrbradley deleted the fix-nightly-upgrade branch August 28, 2024 11:39
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v2.59.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow failure: nightly-sdk-generation
3 participants