DiffResponse.Diffs should contain only top-level keys #3554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3554 +/- ##
==========================================
- Coverage 57.85% 57.79% -0.06%
==========================================
Files 66 66
Lines 8281 8284 +3
==========================================
- Hits 4791 4788 -3
- Misses 3045 3050 +5
- Partials 445 446 +1 ☔ View full report in Codecov by Sentry. |
danielrbradley
approved these changes
Sep 5, 2024
|
This PR has been shipped in release v2.60.0. |
This was referenced Oct 1, 2024
thomas11
added a commit
that referenced
this pull request
Oct 8, 2024
It seems like I accidentally left some debugging code in #3554 that breaks `Diff`. I don't understand how this only comes up now in triage - wouldn't this mess up _all_ the provider's diffs?? Also a good example for the importance of test coverage. We do have tests for the diff algorithm but not for the providers overall `Diff` method. Fixes #3632
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3546
After changing a property of an object in an array property,
pulumi previewwould show an empty[diff: ]. This is because the engine only understands top-level property keys at that place, not paths, as confirmed by @Frassle. This PR normalizes the property name to top-level.Related: pulumi/pulumi#17139