-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve previous default versions in v3 #3748
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't expect SDK changes in this PR. I guess the change affects the v1-v2 comparison, but I don't think we should change v2 retroactively.
4fe892f
to
a02ce56
Compare
4e6e646
to
64156d6
Compare
a02ce56
to
c80f4e6
Compare
Before considering the resources marked for removal, if the resource version was in the previous default version, ensure we include it. Only enable this for the v3 release because it will add a lot more explicit versions.
- Make DefaultVersionLock a type definition instead of an alias. - Add IsAtVersion method. - Refactor usages in ShouldInclude.
c80f4e6
to
ab1ed99
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3748 +/- ##
==========================================
- Coverage 56.92% 56.88% -0.04%
==========================================
Files 76 76
Lines 11877 11885 +8
==========================================
Hits 6761 6761
- Misses 4624 4632 +8
Partials 492 492 ☔ View full report in Codecov by Sentry. |
This PR has been shipped in release v2.76.0. |
Fixes #3424
Before considering the resources marked for removal, if the resource version was in the previous default version, ensure we include it.
Only fix this for v3 onwards so we don't introduce schema changes now.
Bonus:
Stacked on top of #3753