Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the removed EnsureDir #3785

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

mikhailshilkov
Copy link
Member

@mikhailshilkov mikhailshilkov commented Dec 12, 2024

EnsureDir got removed in pulumi/pulumi#17898 which broke https://github.com/pulumi/pulumi-azure-native/actions/runs/12296765290/job/34316443779

This PR replaces it with its one-line implementation.

Fix #3784

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.69%. Comparing base (4d9c25d) to head (d6872a5).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
provider/pkg/gen/emitFiles.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3785      +/-   ##
==========================================
- Coverage   56.70%   56.69%   -0.01%     
==========================================
  Files          78       78              
  Lines       11999    11999              
==========================================
- Hits         6804     6803       -1     
- Misses       4692     4693       +1     
  Partials      503      503              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhailshilkov mikhailshilkov enabled auto-merge (squash) December 12, 2024 18:53
@mikhailshilkov mikhailshilkov merged commit 4cf0738 into master Dec 12, 2024
24 checks passed
@mikhailshilkov mikhailshilkov deleted the mikhailshilkov/emitfiles branch December 12, 2024 18:58
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v2.78.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow failure: weekly-pulumi-update
4 participants