Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azcore fix: initialize request pipeline with configured cloud #3802

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

thomas11
Copy link
Contributor

Fixes #3795, hopefully.

The way Azure's azcore and azidentity SDKs are designed makes it hard to test this, but reading the source here it looks like this change should fix the issue.

@thomas11 thomas11 requested a review from a team December 17, 2024 21:15
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.01%. Comparing base (c57661c) to head (89e784c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3802      +/-   ##
==========================================
+ Coverage   57.00%   57.01%   +0.01%     
==========================================
  Files          78       78              
  Lines       12035    12041       +6     
==========================================
+ Hits         6860     6865       +5     
- Misses       4675     4676       +1     
  Partials      500      500              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mjeffryes mjeffryes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving b/c I don't want to block you on timezone delta and it makes sense that this could fix the issue, but would be nice to capture this requirement in some sort of test or at least a comment.

provider/pkg/azure/client_azcore.go Show resolved Hide resolved
@thomas11 thomas11 force-pushed the tkappler/azcore-token-scope branch from 3bd6a92 to 89e784c Compare December 18, 2024 09:08
@thomas11 thomas11 enabled auto-merge (squash) December 18, 2024 09:23
@thomas11 thomas11 merged commit 1285abd into master Dec 18, 2024
23 checks passed
@thomas11 thomas11 deleted the tkappler/azcore-token-scope branch December 18, 2024 09:42
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v2.79.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New AzCore API Breaks Environment
3 participants