-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azcore fix: initialize request pipeline with configured cloud #3802
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3802 +/- ##
==========================================
+ Coverage 57.00% 57.01% +0.01%
==========================================
Files 78 78
Lines 12035 12041 +6
==========================================
+ Hits 6860 6865 +5
- Misses 4675 4676 +1
Partials 500 500 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving b/c I don't want to block you on timezone delta and it makes sense that this could fix the issue, but would be nice to capture this requirement in some sort of test or at least a comment.
3bd6a92
to
89e784c
Compare
This PR has been shipped in release v2.79.0. |
Fixes #3795, hopefully.
The way Azure's azcore and azidentity SDKs are designed makes it hard to test this, but reading the source here it looks like this change should fix the issue.